address BoundingBoxRigHandle nullreferenceexception #2086
Conversation
[may18] Removing unused Animation script & animation in HolographicButton prefab
|
@cre8ivepark is likely the best to answer the question regarding inputDownEventData. |
|
FYI: OnInputUp is setting inputDownEventData to null, so this exception will happen if a source is lost if not in a down state. |
| public void OnSourceLost(SourceStateEventData eventData) | ||
| { | ||
| if (eventData.SourceId == inputDownEventData.SourceId) | ||
| if ((inputDownEventData != null) && |
There was a problem hiding this comment.
event data should never be null. If it is then, something is being used improperly in another location.
There was a problem hiding this comment.
this class is setting inputDownEventData during an up event. is this the wrong behavior? it has been this way since the start, I believe
There was a problem hiding this comment.
I believe it is wrong, but we can address a fix in vNEXT
There was a problem hiding this comment.
This might be related to those null references in the InputManger you were getting.
event datums should never be null
fix backspace not clearing the last character in the field
|
To reiterate, the change in this PR is to match the Update method and check to see if the cached inputDownEventData is null before attempting to dereference. |
|
this PR got messed up due to me trying to keep it in sync with may18_dev.... going to re-branch and re-submit. |
BoundingBoxRigHandle has a potential to encounter a NullReferenceException in OnSourceLost. This change avoids the exception as well as moving the call to eventData.Use inside the if block.
This MAY be related to what was reported in #2009. I was unable to reproduce the exact issue when I encountered this one.