Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable keyboard caret, move test scene #2132

Merged
merged 3 commits into from
May 18, 2018
Merged

Re-enable keyboard caret, move test scene #2132

merged 3 commits into from
May 18, 2018

Conversation

david-c-kline
Copy link

Overview

This change re-enables the caret in the MRTK keyboard. This MAY result in both the MRTK and System keyboards being displayed at the same time (#1940) -- we will continue to investigate this issue separately. Submitting this as not having a caret is a significant usability issue.

The keyboard test scene has been moved from Examples\Input to Examples\UX to avoid confusion, as that is where the scripts reside.

Fixes: #1978

Copy link
Contributor

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use the API compatibility checker to see if the OS Supports the latest in order to know if we should show the Prefab Keyboard or not.

@david-c-kline
Copy link
Author

possibly, but not 100% from what I have investigated

@david-c-kline david-c-kline merged commit 6f0934d into microsoft:may18_dev May 18, 2018
@david-c-kline david-c-kline deleted the kbd1978 branch May 18, 2018 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants