Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard dication input fixes #2210

Merged
merged 3 commits into from
May 30, 2018
Merged

Keyboard dication input fixes #2210

merged 3 commits into from
May 30, 2018

Conversation

LocalJoost
Copy link
Contributor

Fixes two issues with the dictation of the keyboard.

  1. The DictationInputManager never really stops recognizing. The DictiationRecognizer.Stop() fails with a "Assertion failed on expression: 'SUCCEEDED(hr)'" and internal state is not reset properly after that
  2. If the user gazes at the keyboard while doing a dictation, the event speech event arrives twice.

Fixes:

  1. Everything after the DictiationRecognizer.Stop is put into a separate coroutine. As a lot of stuff in the DictationInputManager is static, and there was some internal replumbing necessary to make it a) work and b) not break the interface.
  2. In Keyboard.OnDictationResult now the eventData.used is checked. If true, input is ignored. If not, it is set to true after processing the input.

@david-c-kline david-c-kline merged commit 0c5cad9 into microsoft:may18_dev May 30, 2018
@LocalJoost LocalJoost deleted the Keyboard_dication_input_fixes branch May 31, 2018 11:25
@LocalJoost LocalJoost restored the Keyboard_dication_input_fixes branch May 31, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants