Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in TryGetBoundaryRectanglePoints after teleport #2481

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

keveleigh
Copy link
Contributor

@keveleigh keveleigh commented Jul 24, 2018

Overview

After a teleport, the boundary APIs still return positions around the origin, as though the camera has not moved.

I previously updated the RectangleParams method, but did not transform the RectanglePoints method. This fixes that.

Changes

Copy link
Contributor

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to get ported into vNEXT?

@keveleigh
Copy link
Contributor Author

@StephenHodgson
@davidkline-ms and I made sure it was accounted for in #2469 (this method ended up not existing there as written here, so we're good).

@keveleigh keveleigh merged commit 95547c1 into microsoft:june18_dev Jul 24, 2018
@keveleigh keveleigh deleted the TeleportFix branch July 24, 2018 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants