-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TextToSpeechManager to support dynamic speech #26
Conversation
Hi @jbienzms, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
/// </remarks> | ||
public class TextToSpeechManager : Singleton<TextToSpeechManager> | ||
{ | ||
#region Region Name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the default region name was accidentally left in! Also, since each region really only contains one variable/method, it might be okay to leave them all out.
We haven't really been using regions in the Toolkit so far, so style-matching-wise it might be best to remove them. Others can weigh in with their opinions though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not tied to the regions. I'm willing to let them go for the sake of matching style.
…our instead of Singleton, fixed a spelling error, and regions were removed. Also added the ability to speak SSML which was omitted from the original submission.
About to submit a new pull request with all of the above change requests implemented, so I'll close this pull request. |
…interUpdates Updated angle math and removed the need for the 90 degree offset
…ple-Feedback MRH3-62 Eye Tracking Examples Feedback
Please note that the code for TextToSpeechManager is 100% new code by
me. However, portions of the Wav class were based on this sample:
http://answers.unity3d.com/questions/737002/wav-byte-to-audioclip.html
The author does release that code for others to use and I have
attributed the article in the class comments, but if this source
is not acceptable we will need to rewrite the WAV class.
Here are the steps for adding Text to Speech to your own apps: