Updating the HTK's drop of UnityGLTF with the correct coordinate space #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating with contents of KhronosGroup/UnityGLTF@9be32fb, but not the Shader work done right before.
keveleigh
added
Ready for Review
Legacy (HoloToolkit)
david-c-kline
approved these changes
Aug 25, 2018
|
|
||
| yield return gltfScript.WaitForModelLoad(); | ||
| var sceneImporter = new GLTFSceneImporter( | ||
| "", |
There was a problem hiding this comment.
I think it's fine as-is. If for perf concerns, it appears there's no real difference:
There was a problem hiding this comment.
Yeah no difference there, just easier to spot and read imo
There was a problem hiding this comment.
Ahh, I see! I wasn't sure what you were asking from your original comment.
StephenHodgson
approved these changes
Aug 25, 2018
This was referenced Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The drop of UnityGLTF we currently have is outdated with regards to the Z forward direction. More information can be found at KhronosGroup/glTF#1043.
This PR does a minor update (not to the latest) of UnityGLTF in order to resolve this coordinate space discrepancy.