Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed teleport animations/scripts to not reset animator state #8781

Conversation

RogPodge
Copy link
Contributor

@RogPodge RogPodge commented Oct 10, 2020

#Overview
Previously the SetVisibility function would set the hand visual object as active/inactive for the teleport cursor. This interfered with the cursor since it's animation state was tied to the hand visual object. This PR changes the SetVisiblity script and the animation so that they no longer conflict with each other.

handteleportfix

Changes

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

@keveleigh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@RogPodge
Copy link
Contributor Author

no visual teleport pointer related regressions when testing on Quest as a heads up

@david-c-kline
Copy link

looks good to me. i will defer to @cre8ivepark for final verdict

Copy link
Contributor

@cre8ivepark cre8ivepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@RogPodge RogPodge merged commit 82e7dd8 into microsoft:prerelease/2.5.1_upm_stabilization Oct 11, 2020
@david-c-kline david-c-kline added this to the MRTK 2.5.1 UPM milestone Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants