Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Utility Tools Update #887

Merged
merged 19 commits into from
Sep 2, 2017
Merged

Editor Utility Tools Update #887

merged 19 commits into from
Sep 2, 2017

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Aug 24, 2017

@Zod-
Copy link

Zod- commented Aug 24, 2017

@StephenHodgson
Copy link
Contributor Author

Thanks @Zod- I'll be sure to add these to the update.

@StephenHodgson StephenHodgson changed the title Editor Tools Update Editor Utility Tools Update Aug 25, 2017
@@ -30,6 +31,8 @@ protected override void ApplySettings()
ApplySetting(PlayerSettings.WSACapability.SpatialPerception);
ApplySetting(PlayerSettings.WSACapability.WebCam);
ApplySetting(PlayerSettings.WSACapability.InternetClient);
ApplySetting(PlayerSettings.WSACapability.InternetClientServer);
ApplySetting(PlayerSettings.WSACapability.PrivateNetworkClientServer);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this capability used for in the Toolkit that isn't covered by InternetClientServer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes back to our prev conversation in the update PR haha.

I'll apply those learnings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation for win 10 capabilities hasn't been updated recently. Keeps sending me back to win 8.

Copy link
Contributor

@keveleigh keveleigh Aug 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, yeah, that's definitely a stale link. Here's the Win10 documentation.

@StephenHodgson
Copy link
Contributor Author

Can I get a second review on this? I'd like to get it in before publishing a new release.

@StephenHodgson
Copy link
Contributor Author

@Zod- or @jamesashley1 would either of you like to submit a review?

Copy link

@jessemcculloch jessemcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was able to build out to HoloLens without issue.

@StephenHodgson StephenHodgson merged commit 813d94b into microsoft:master Sep 2, 2017
@StephenHodgson StephenHodgson deleted the HTK-IconGenUpdate branch September 2, 2017 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants