Fix for mismatched Mic network stream #930
Conversation
StephenHodgson
changed the title
| @@ -271,9 +271,9 @@ private void SendFixedSizedChunk(NetworkConnection connection, byte[] data, int | |||
| msg.Write(cameraPosRelativeToGlobalAnchor.z); | |||
|
|
|||
| // HRTF direction bits | |||
There was a problem hiding this comment.
Is there a reason we are leaving this in commented out, vs just deleting the section?
There was a problem hiding this comment.
Because potentially someone could implement the hrtf parts.
There was a problem hiding this comment.
But the current implementation is wrong? Sorry, i don't know much about this stuff.
There was a problem hiding this comment.
Yeah it's causing a mismatch in the stream in the receiving end.
There was a problem hiding this comment.
Got it. Seems like maybe we should just put a TODO in on the Transmitter like in the Receiver. Or put a comment in on why that code is commented out.
Personally I'm not a big fan of leaving commented code in.
There was a problem hiding this comment.
I could comment it back in on the receiving end too, but I figured this way was saving network traffic.
Fixes #786