Fixing remote mapping for IL2CPP support

[keveleigh]

See #265

This also fixes a bug where spatial mapping file saving didn't properly get data from the remote mapping source.

[angelaHillier]

Worked for my project. Thanks!

[StephenHodgson]

Should this be ported to the master branch as well?

[keveleigh]

@StephenHodgson Yep, it should! I put it in this branch first, since porting efforts to Windows Mixed Reality are more likely to come from IL2CPP, as opposed to HoloLens apps. It's definitely a fix that needs to go everywhere though.

Edit: Actually, the remote mapping fix is really a HoloLens specific fix too.

[StephenHodgson]

Good to hear. Please be sure to keep the issue open until it's merged into the master branch.

[StephenHodgson]

In fact I wouldn't mind seeing a new PR for this along side this one.

[keveleigh]

Will do! I believe GitHub does that by default, auto-closing the issue when the PR actually gets merged into master.

[StephenHodgson]

Just have to remove the first line of your initial comment to prevent that.

I'd change it to See: #265 instead of Fixes.

[keveleigh]

I think this is the preferred way to do it, since GitHub doesn't close the issue until the PR is merged into the default branch.

Of course, if we're merging a separate PR into master, the contents of this one doesn't really matter haha.

[StephenHodgson]

That's what I'm saying. I would like to close the issue with the other PR because it's on the master branch.

[keveleigh]

It's possible I'm misunderstanding, since merging this into the dev branch would not have closed the issue automatically, but I changed the wording anyway.

[StephenHodgson]

Ah I see. Thanks for clarifying

[keveleigh]

PR into master opened: #965