update to BuildAndDeploy #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keveleigh
reviewed
Sep 17, 2017
| { | ||
| return null; |
There was a problem hiding this comment.
Does anything check for this returning null? Looks like now it'll return string.Empty if nothing is found.
There was a problem hiding this comment.
The check is string.IsNullOrEmptyon the receiving end, so it shouldn't make any difference.
There was a problem hiding this comment.
It probably should have been returning string.Empty instead of null anyway.
keveleigh
approved these changes
Sep 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #969
Fixes #982