Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xbox Controller Updates #994

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Xbox Controller Updates #994

merged 1 commit into from
Sep 20, 2017

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Sep 20, 2017

  • Addresses some feedback from @keveleigh.
  • Adds a None enum to the XboxControllerMappingTypes that will break all existing settings.
    • Sorry, None should have been there from the beginning!
  • Added a XboxControllerHanderBase for easily creating your own implementations.
    • Handy helper functions for getting buttons based on enum to change/update inputs on the fly.
  • Added optional parameters to XboxControllerSource when overriding events on the StandaloneInputModule

@SimonDarksideJ
Copy link
Contributor

Was looking at how to bring this forward to the Develop2017.2 branch, however these classes have been removed there :S

@keveleigh
Copy link
Contributor

keveleigh commented Sep 21, 2017

@DDReaper These classes never existed there; these are new, added to master in #936. The Dev branch has an implementation of Gamepad input, mostly in GamepadInput.cs, which added "gesture" support via the gamepad, but not discrete button mappings.

@SimonDarksideJ
Copy link
Contributor

Ok, I'll check that out, as I'm getting no input from the Wireless Original Xbox One controller currently @keveleigh (Just tested your PR)
Controller works fine in MRPortal.

@StephenHodgson
Copy link
Contributor Author

@DDReaper, did you implement the InputManager.asset?

@StephenHodgson StephenHodgson deleted the MRTK-XboxControllerUpdates branch September 22, 2017 15:50
@SimonDarksideJ
Copy link
Contributor

Ok, figured out the problem. As noted in #964 , the base dev branch is broken for Immersive headsets.
Headmovement and gaze functions, but the MR camera is floating and Xbox controllers don't work. Fixed by pulling in @keveleigh s fixes

@StephenHodgson
Copy link
Contributor Author

@DDReaper this PR has nothing to do with the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants