Remove absorbing of running instance #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
This was referenced Jan 20, 2024
Closed
2 tasks
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Jan 24, 2024
* add bitwise AND example (microsoft#289) * add bitwise AND example * fix cargo clippy * Fix typos (microsoft#290) * fix typo * fix typo * Fix typo * Remove absorbing of running instance (microsoft#291) * Remove absorbing of running instance * Update value of NUM_FE_FOR_RO * Update expected values in tests * Add comment * cargo fmt * relax requirements on the size of public IO and add a note about NIFS (microsoft#294) * relax requirements on the size of public IO * add a note --------- Co-authored-by: Srinath Setty <[email protected]> Co-authored-by: GoodDaisy <[email protected]> Co-authored-by: Varun Thakore <[email protected]>
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Feb 2, 2024
* Improve rustdoc - Updated references in documentation comments, changing from Kotlin-style to rustdoc style. - Corrected the use of brackets to backticks for proper Rust code referencing in the comments in the `lib.rs` and `r1cs/mod.rs` files. - The changes made were purely stylistic and cosmetic. No modifications were made to the actual code logic or implementation. * doc: fix Rustdoc - Updated hyperlink format in `HyperKZG` module documentation. - CI should be testing this when rust-lang/rust#56232 resolves.
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Feb 20, 2024
- Refactored the 'prove_mut' function in 'nifs.rs' - Removed the necessity of absorbing U1 in the `absorb_in_ro` function, reducing redundant steps.
huitseeker
added a commit
to argumentcomputer/Nova
that referenced
this pull request
May 2, 2024
- Refactored the 'prove_mut' function in 'nifs.rs' - Removed the necessity of absorbing U1 in the `absorb_in_ro` function, reducing redundant steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is corresponding to issue #56. It removes absorbing of running instance and updates the value of
NUM_FE_FOR_ROand expected values in tests.