-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix random windows CI failure #1057
Closed
Closed
+149
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guotuofeng
force-pushed
the
myguo/ci_fail
branch
from
April 8, 2024 06:40
8fb2331
to
df8ad64
Compare
guotuofeng
changed the title
WIP: enable azure identity logging
Fix random windows CI failure
Apr 8, 2024
#1060 fix the issue by managed identity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
AzureCliCredential: ERROR: AADSTS700024: Client assertion is not within its valid time range. Current time: 2024-04-08T03:00:10.8235174Z, assertion valid from 2024-04-08T02:29:38.0000000Z, expiry time of assertion 2024-04-08T02:39:38.0000000Z. Review the documentation at https://docs.microsoft.com/azure/active-directory/develop/active-directory-certificate-credentials . Trace ID: 9e51fd4c-88a8-4c52-b862-5daaf31d2400 Correlation ID: 55cbfee9-c8b7-4627-91ba-36cfcaa58ae8 Timestamp: 2024-04-08 03:00:10Z
Interactive authentication is needed. Please run:
az login
From the error message, it seems the idToken is about 10 minutes. From ERROR: AADSTS700024: Client assertion is not within its valid time range Azure/login#180 (comment) and https://devblogs.microsoft.com/devops/public-preview-of-workload-identity-federation-for-azure-pipelines/#comment-4001, it might/might not be the azure service connection issue.
How to fix/work around: in this PR, I adjust the execution order of aml_system and local_system to make sure the idToken is not expired since of the 10 minutes timeout.
Let's wait and rerun to check whether the CI failure is fixed or not.
Checklist before requesting a review
lintrunner -a
(Optional) Issue link