Write configs as part of conversion pass #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaahji
force-pushed
the
shaahji/genaicfgs
branch
from
967e474
to
15ff89b
Compare
guotuofeng
reviewed
Apr 18, 2024
shaahji
force-pushed
the
shaahji/genaicfgs
branch
from
15ff89b
to
4443e16
Compare
shaahji
force-pushed
the
shaahji/genaicfgs
branch
2 times, most recently
from
3498962
to
b49c8a4
Compare
For generative models using GenAI model builder, when using ONNX model as input configs (config.json, generation_config.json & tokenizer) are required inputs. So, write out these files as outputs from the conversion pass.
shaahji
force-pushed
the
shaahji/genaicfgs
branch
from
b49c8a4
to
fed7de9
Compare
jambayk
approved these changes
Apr 19, 2024
guotuofeng
reviewed
Apr 19, 2024
guotuofeng
reviewed
Apr 19, 2024
DavitGrigoryan132
pushed a commit
to DavitGrigoryan132/Olive
that referenced
this pull request
Aug 14, 2024
## Write configs/metadata as part of conversion pass For generative models using GenAI model builder, when using ONNX model as input configs (config.json, generation_config.json & tokenizer) are required inputs. So, write out these files as outputs from the conversion pass. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write configs as part of conversion pass
For generative models using GenAI model builder, when using ONNX model as input configs (config.json, generation_config.json & tokenizer) are required inputs. So, write out these files as outputs from the conversion pass.
Checklist before requesting a review
lintrunner -a(Optional) Issue link