Fix handling of extra_args for ModelBuilder pass #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GenAI model builder's extra_args works based on existence of a key rather then the value of the key itself. So, Olive cannot pass a key with a value of true/false. The key has to explicitly be added/removed based on the value of the key itself in the user config.
jambayk
approved these changes
Apr 27, 2024
jambayk
reviewed
Apr 27, 2024
| if config["exclude_lm_head"]: | ||
| extra_args["exclude_lm_head"] = config["exclude_lm_head"] | ||
|
|
||
| if config["enable_cuda_graph"] is not None: |
There was a problem hiding this comment.
nit: this condition is not needed since the value is always a bool and this condition is always true.
DavitGrigoryan132
pushed a commit
to DavitGrigoryan132/Olive
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling of extra_args for ModelBuilder pass
GenAI model builder's extra_args works based on existence of a key rather then the value of the key itself. So, Olive cannot pass a key with a value of true/false. The key has to explicitly be added/removed based on the value of the key itself in the user config.
Checklist before requesting a review
lintrunner -a(Optional) Issue link