Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL: use str.isdigit instead of try/except #1126

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

jambayk
Copy link
Contributor

@jambayk jambayk commented Apr 30, 2024

Describe your changes

Fixes https://github.com/microsoft/Olive/security/code-scanning/10748 and https://github.com/microsoft/Olive/security/code-scanning/10747.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

@jambayk jambayk requested a review from guotuofeng April 30, 2024 01:14
@jambayk jambayk merged commit 9e7d426 into main Apr 30, 2024
35 checks passed
@jambayk jambayk deleted the jambayk/is-digit branch April 30, 2024 04:46
DavitGrigoryan132 pushed a commit to DavitGrigoryan132/Olive that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants