Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DML execution provider #1130

Merged
merged 1 commit into from
May 1, 2024
Merged

Add support for DML execution provider #1130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions olive/passes/onnx/model_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from pathlib import Path
from typing import Any, Dict, Union

from olive.hardware.accelerator import AcceleratorLookup, AcceleratorSpec, Device
from olive.hardware.accelerator import AcceleratorSpec, Device
from olive.model import ONNXModelHandler, PyTorchModelHandler
from olive.model.utils import resolve_onnx_path
from olive.passes import Pass
Expand Down Expand Up @@ -86,7 +86,7 @@ def _default_config(cls, accelerator_spec: AcceleratorSpec) -> Dict[str, PassCon
),
"enable_cuda_graph": PassConfigParam(
type_=bool,
default_value=False,
default_value=None, # Explicitly setting to None to differentiate between user intent and default.
required=False,
description=(
"The model can use CUDA graph capture for CUDA execution provider. "
Expand All @@ -102,13 +102,12 @@ def validate_search_point(
if with_fixed_value:
search_point = self.config_at_search_point(search_point or {})
precision = search_point.get("precision")
device = (
Device.CPU
if self.accelerator_spec.execution_provider
in AcceleratorLookup.get_execution_providers_for_device(Device.CPU)
else Device.GPU
)
if precision == ModelBuilder.Precision.FP16 and device == Device.CPU:

# if device is GPU, but user choose CPU EP, the is_cpu should be True
if (precision == ModelBuilder.Precision.FP16) and not (
accelerator_spec.accelerator_type == Device.GPU
and accelerator_spec.execution_provider != "CPUExecutionProvider"
):
logger.info(
"FP16 is not supported on CPU. Valid precision + execution"
"provider combinations are: FP32 CPU, FP32 CUDA, FP16 CUDA, INT4 CPU, INT4 CUDA"
Expand Down Expand Up @@ -152,12 +151,12 @@ def _run_for_config(
else Path(resolve_onnx_path(output_model_path, model.onnx_file_name))
)

target_execution_provider = (
"cpu"
if self.accelerator_spec.execution_provider
in AcceleratorLookup.get_execution_providers_for_device(Device.CPU)
else "cuda"
)
if self.accelerator_spec.execution_provider == "DmlExecutionProvider":
target_execution_provider = "dml"
elif self.accelerator_spec.execution_provider == "CUDAExecutionProvider":
target_execution_provider = "cuda"
else:
target_execution_provider = "cpu"

# Select cache location based on priority
# HF_CACHE (HF >= v5) -> TRANSFORMERS_CACHE (HF < v5) -> local dir
Expand Down
Loading