-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept device and dtype in OnnxConversion
, Add OnnxBnb4Quantization
, llama2 e2e qlora example
#703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guotuofeng
reviewed
Nov 8, 2023
guotuofeng
reviewed
Nov 8, 2023
guotuofeng
reviewed
Nov 8, 2023
guotuofeng
reviewed
Nov 8, 2023
guotuofeng
reviewed
Nov 8, 2023
guotuofeng
reviewed
Nov 8, 2023
trajepl
reviewed
Nov 8, 2023
guotuofeng
approved these changes
Nov 8, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
OnnxConversion
_convert_model_on_device
and_convert_distributed_model_on_device
have similar signature and behavioruse_device
: users can specify what device to run conversion on. For example, there is enough gpu memory to speed up conversion or model is float16.torch_dtype
: torch data type to cast the model to before conversion. For example, model is originally float16 but want to convert on cpu and run another pass later to convert to float16.hf_config
.torch_dtype
OnnxBnb4Quantization
MatMulBnb4
quantizer and contrib opquantized_modules
andquantization_config
MaMul
nodes, only the ones that were originally quantized in the source model to retain accuracyllama2
Checklist before requesting a review
pre-commit run --all-files
OnnxConversion
pass has new parametersuse_device
andtorch_dtype
for more flexible conversion.New
OnnxBnb4Quantization
to quantize an ONNX model usingFP4/NF4
data types.(Optional) Issue link