Avoid buffering JSON data into a new MemoryStream during parsing #1857
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieKimani1
requested review from
irvinesunday,
darrelmiller,
millicentachieng and
andrueastman
as code owners
|
darrelmiller
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON data can be read asynchronously, which means that when you receive a stream of JSON data (e.g., from a file, network, or database), you can process the data directly without needing to load it all into memory first.
This increases efficiency by reducing memory usage and allowing the program to respond faster, especially in cases with large or streaming data.
In contrast, YAML does not support asynchronous reading in most libraries, requiring the data to be fully buffered before processing it synchronously.
Fixes #1853