Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for node.js version 18.18.2 #2201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for node.js version 18.18.2 #2201

wants to merge 1 commit into from

Conversation

nunoalima
Copy link

@nunoalima nunoalima commented Oct 19, 2023 •
edited
Loading

This PR adds platform binary and runtime image support for Node 18.18.2, which includes CVE fixes as a follow up to Node.js latest Security Releases.

This is a requirement for developers that are using Oryx to build both static applications and Azure Functions using Microsoft's Azure/static-web-apps-deploy GitHub actions step.

  • The purpose of this PR is explained in this message or in an issue.
  • Tests are included and/or updated for code changes.
  • Proper license headers are included in each file.

A few questions:

  • Do I need to update the NODE_RUNTIME_BASE_TAG?
  • Shall I include older patch versions for the same minor (18.18.0 and 18.18.1)?
  • Are there any tests I should be running other than testStartupScriptGenerators.sh?

@nunoalima nunoalima requested a review from a team as a code owner October 19, 2023 11:02
@kumaraksh1
Copy link
Collaborator

Hey nunoalima,
We are going to generate node images with latest patch version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nunoalima @kumaraksh1