Allow .NET SDK versions to be provided with --platform-version argument
#2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniv-msft
reviewed
Nov 4, 2023
| @@ -435,24 +459,5 @@ private string GetRuntimeVersionUsingHierarchicalRules(string detectedVersion) | |||
| var defaultVersion = this.versionProvider.GetDefaultRuntimeVersion(); | |||
| return defaultVersion; | |||
| } | |||
|
|
|||
| private bool TryGetExplicitVersion(out string explicitVersion) | |||
There was a problem hiding this comment.
Was this one just never used?
|
@cormacpayne Overall looks good to me, but I would prefer not to push it before .NET 8 GA. Do you see any urgency in getting this one in? |
william-msft
previously approved these changes
Nov 6, 2023
…x-dotnet-sdk-detect
…soft/oryx into corm/fix-dotnet-sdk-detect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only runtime versions can be provided to the
--platform-versionargument fororyx build, preventing users from specifying a specific version of the .NET SDK they'd like to build with (instead they'd need to know the corresponding runtime version shipped with the SDK version they want to use).This PR cleans up the logic around the version that can be provided and detected to account for SDK versions, while still respecting the runtime version logic we currently have in place.
- [ ] Proper license headers are included in each file.