Update the builder with new lifecycle binaries and base builder image #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cormacpayne
commented
Nov 15, 2023
cormacpayne
commented
- The purpose of this PR is explained in this message or in an issue. If an issue please include a reference as #<issue_number>.
- Tests are included and/or updated for code changes.
- Proper license headers are included in each file.
…a-debian-bullseye-20231017.1-builder
pauld-msft
previously approved these changes
Nov 28, 2023
daniv-msft
reviewed
Nov 29, 2023
builders/container-apps/Dockerfile
Outdated
| @@ -8,15 +8,20 @@ FROM ${BASE_BUILDER_IMAGE} | |||
| # ACR_SCOPE: scope that the image will need to push to the ACR, e.g. repository:app/capps-runnable-app:pull,push | |||
| # MI_PRINCIPAL_ID: principal id of the managed identity that will allow the image to push to the specified ACR | |||
| ENV APP_IMAGE="" \ | |||
| ACR_RESOURCE_NAME="" \ | |||
| ACR_RESOURCE_NAME="private-repository-k8s.k8se-system" \ | |||
There was a problem hiding this comment.
Could you please confirm why we need to specify this specifically? If we could avoid having a hard dependency on the Kubernetes resource name/namespace, it would be a lot more resilient to breaking changes.
daniv-msft
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.