Fix docker file path for python runtime images #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To generate the runtime base images, dockerfiles are generated on the fly and the same file is used to create the image.
While creating the docker files for Python, path is different from what is used while building the image.
Look here.
https://github.com/microsoft/Oryx/blob/8b3ac454331efe1b7934439f06cc7ece42c01613/build/buildRunTimeImageBases.sh#L80C1-L80C59
Tested the change with the PR - https://github.com/microsoft/Oryx/pull/2359/files