Issue 406 #555
Merged
Issue 406 #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds assertions for invalid content sizes
Fixes sending XAML as wrong type.
|
👍 |
1 similar comment
|
👍 |
|
There are some hard coded colors in the adornment code, we should check it all looks right in all 3 themes. |
|
They're hardcoded because the images from matplotlib have hardcoded defaults too (including a transparent background). Forcing a white background on those images is necessary for all themes, and the other colours appear on top of that background. But I'd checked that it looked fine already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #406 Interactive window images do not zoom
Replaces the standard intraline adornment with our own one.
Also handles generic XAML as forwards-compatibility preparation.