Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated new image for HomeScreen #1068

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Updated new image for HomeScreen #1068

merged 1 commit into from
Aug 25, 2021

Conversation

vasavib
Copy link
Contributor

@vasavib vasavib commented Aug 24, 2021

When submitting a connector, please check the following conditions for your PR to ensure a smooth certification process.

  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@vasavib vasavib requested a review from a team as a code owner August 24, 2021 23:42
sriyen-msft
sriyen-msft requested changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@sriyen-msft sriyen-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vasavib I can see few Secret-look-a-like values in the image, Can you please let us know if you are exposing any security related information in the image ?

@vasavib
Copy link
Contributor Author

vasavib commented Aug 25, 2021 via email

@sriyen-msft
Copy link
Contributor

Hi Srikanth, Can you tell me which particular fields in the screenshot below appear like security related info? This is all data from trial servicenow instance and nothing related to production. Let me know if this is still of concern and I can update the screenshot accordingly. @.*** From: Srikanth Yenagandhula @.> Sent: Tuesday, August 24, 2021 5:32 PM To: microsoft/PowerPlatformConnectors @.> Cc: Vasavi Bhaviri Setty @.>; Mention @.> Subject: Re: [microsoft/PowerPlatformConnectors] Updated new image for HomeScreen (#1068) @sriyen-msft requested changes on this pull request. @vasavibhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvasavib&data=04%7C01%7CVasavi.Bhaviri%40microsoft.com%7Cffe5e065b40b453ce43e08d9675fb008%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637654482951164524%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=WY2e8%2FU2kG9S6NO3Jfzrbo9YMNJtdNbxEKGH87ahvA4%3D&reserved=0 I can see few Secret-look-a-like values in the image, Can you please let us know if you are exposing any security related information in the image ? - You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FPowerPlatformConnectors%2Fpull%2F1068%23pullrequestreview-737797074&data=04%7C01%7CVasavi.Bhaviri%40microsoft.com%7Cffe5e065b40b453ce43e08d9675fb008%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637654482951164524%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=cVSz0VTPIC3gU%2FZJehfeiw6EwFSGBGeEXHq6%2F9nCYK8%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFAGOVMY3AD4SC5UZQNCODTT6Q2WHANCNFSM5CX3QW3Q&data=04%7C01%7CVasavi.Bhaviri%40microsoft.com%7Cffe5e065b40b453ce43e08d9675fb008%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637654482951174478%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=c6WTLf3itseMhGgyYTrp860p6%2Fkj40P7yQlNbTKUvPs%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7CVasavi.Bhaviri%40microsoft.com%7Cffe5e065b40b453ce43e08d9675fb008%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637654482951174478%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=0si1LE3VvnjIAxj86gDAhABGMwliUsccEAOXJvsIKBs%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26utm_campaign%3Dnotification-email&data=04%7C01%7CVasavi.Bhaviri%40microsoft.com%7Cffe5e065b40b453ce43e08d9675fb008%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637654482951174478%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=lF7ctLJ2I5jtzfZVJr2U5CBt1tFsdS6sp8lqHk9M6%2Bo%3D&reserved=0.

@vasavib We usually get security alerts from Microsoft Security tools even for secret-look-a-like values, For example: the screenshot has a field called "Issue with email" which has a GUID, looks more like a secret. I understood that this connector is custom-connector and would not go into production regions. But we need to provide justification to the security alerts to mitigate them. I can go ahead with the information you have provided. Thanks

@sriyen-msft sriyen-msft merged commit 92ca0d7 into microsoft:dev Aug 25, 2021
joshuaapple pushed a commit to docjuris/PowerPlatformConnectors that referenced this pull request Oct 6, 2021
@vasavib @joshuaapple
Updated new image for HomeScreen (microsoft#1068)
db187a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriyen-msft sriyen-msft sriyen-msft approved these changes

Assignees
No one assigned
Labels
custom-connector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasavib @sriyen-msft