Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Share-Effect] Fix status codes #1227

Merged
merged 11 commits into from
Nov 12, 2021
Merged

Conversation

Rens-Braspenning
Copy link
Contributor


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@Rens-Braspenning Rens-Braspenning changed the title Fix status codes [Share-Effect] Fix status codes Oct 28, 2021
@sriyen-msft
Copy link
Contributor

@ptalrejagithub Can you please approve this PR as it is asking for 2 approvals?

@sriyen-msft sriyen-msft added needs:attention Needs attention from Microsoft or community and removed Validation phase Connector is being validated by Microsoft. needs:partner-attention labels Nov 1, 2021
@sriyen-msft sriyen-msft merged commit c776793 into microsoft:master Nov 12, 2021
robin-larsson pushed a commit to robin-larsson/PowerPlatformConnectors that referenced this pull request Jan 11, 2022
* Update apiDefinition.swagger.json

* merged

* Removed empty value properties

* Update apiDefinition.swagger.json

* Update apiProperties.json

* Update apiDefinition.swagger.json

* Update apiDefinition.swagger.json

Co-authored-by: Rens Braspenning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
certified-connector needs:attention Needs attention from Microsoft or community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants