Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please merge this changes #2641

Merged
merged 10 commits into from
May 23, 2023
Merged

Please merge this changes #2641

merged 10 commits into from
May 23, 2023

Conversation

stsiek
Copy link
Contributor

@stsiek stsiek commented May 12, 2023


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@stsiek stsiek requested a review from a team as a code owner May 12, 2023 01:07
@stsiek stsiek closed this May 12, 2023
@stsiek stsiek reopened this May 12, 2023
@stsiek
Copy link
Contributor Author

stsiek commented May 12, 2023

Please merge this changes.
Some of the actions are deprecated, that is why they are defined as internal (hidden).

Copy link
Contributor Author

@stsiek stsiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are indeed aware of all points and think we have tested everything well. we would then test it again in the preview environment for existing flows. thank you very much for the hints. so we have no further concerns and think it can be merged.

Copy link
Contributor Author

@stsiek stsiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are indeed aware of all points and think we have tested everything well. we would then test it again in the preview environment for existing flows. thank you very much for the hints. so we have no further concerns and think it can be merged.

@stsiek stsiek closed this May 16, 2023
@stsiek stsiek reopened this May 16, 2023
@stsiek
Copy link
Contributor Author

stsiek commented May 16, 2023

we have now set some actions to deprecated. all other points are no problem from our point of view and should continue to work with our service.

@Amjed-Ayoub
Copy link
Contributor

we have now set some actions to deprecated. all other points are no problem from our point of view and should continue to work with our service.

@stsiek you are not seeing issues because you are an internal user for your connector, so changing the action from important to Internal will not affect your flows or apps but it will break all external users flows and apps :-).

@stsiek
Copy link
Contributor Author

stsiek commented May 18, 2023

all right, thanks for the explanation. we have now set all of them back from "internal" to "important", except for the ones that should remain "internal". are there any points still open at the moment or can it already be merged?

@stsiek stsiek closed this May 22, 2023
@stsiek
Copy link
Contributor Author

stsiek commented May 22, 2023

Are there any points still open at the moment or can it already be merged? We would like to submit the changes promptly because we need them promptly. Thank you for checking

@stsiek stsiek reopened this May 22, 2023
Copy link
Contributor

@Amjed-Ayoub Amjed-Ayoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @stsiek ,
I hope you are doing well.
Congratulations, your pull request is approved and merged. Please submit the files to ISV Studio or update your submission using your latest commit ID, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio. Please make sure that the icon meets all the requirements, that it’s size is 230x230, icon background is not white or transparent and it matches the iconBrandColor property in apiProperties.json file.
After making the submission in ISV Studio, please attach an intro.md file in the activity control section. This file is required and it's different from readme.md. You can find an example of intro.md file on this page at step 6.
Please Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector.
We expect all tests to be completed within 1-2 weeks.
If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions.
Please let me know if you have any questions or run into any problems while creating or updating your submission.
Thank you very much for working with us.

@Amjed-Ayoub Amjed-Ayoub merged commit 01e6af6 into microsoft:dev May 23, 2023
@Amjed-Ayoub Amjed-Ayoub removed Validation phase Connector is being validated by Microsoft. needs:partner-attention labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants