-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please merge this changes #2641
Conversation
- Regular Expression - Convert JSON to Excel - Create Word file
Please merge this changes. |
certified-connectors/Converter by Power2Apps/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
certified-connectors/Converter by Power2Apps/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
certified-connectors/Converter by Power2Apps/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
certified-connectors/Converter by Power2Apps/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
certified-connectors/Converter by Power2Apps/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are indeed aware of all points and think we have tested everything well. we would then test it again in the preview environment for existing flows. thank you very much for the hints. so we have no further concerns and think it can be merged.
certified-connectors/Converter by Power2Apps/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
certified-connectors/Converter by Power2Apps/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
certified-connectors/Converter by Power2Apps/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
certified-connectors/Converter by Power2Apps/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
certified-connectors/Converter by Power2Apps/apiDefinition.swagger.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are indeed aware of all points and think we have tested everything well. we would then test it again in the preview environment for existing flows. thank you very much for the hints. so we have no further concerns and think it can be merged.
we have now set some actions to deprecated. all other points are no problem from our point of view and should continue to work with our service. |
@stsiek you are not seeing issues because you are an internal user for your connector, so changing the action from important to Internal will not affect your flows or apps but it will break all external users flows and apps :-). |
all right, thanks for the explanation. we have now set all of them back from "internal" to "important", except for the ones that should remain "internal". are there any points still open at the moment or can it already be merged? |
Are there any points still open at the moment or can it already be merged? We would like to submit the changes promptly because we need them promptly. Thank you for checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @stsiek ,
I hope you are doing well.
Congratulations, your pull request is approved and merged. Please submit the files to ISV Studio or update your submission using your latest commit ID, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio. Please make sure that the icon meets all the requirements, that it’s size is 230x230, icon background is not white or transparent and it matches the iconBrandColor property in apiProperties.json file.
After making the submission in ISV Studio, please attach an intro.md file in the activity control section. This file is required and it's different from readme.md. You can find an example of intro.md file on this page at step 6.
Please Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector.
We expect all tests to be completed within 1-2 weeks.
If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions.
Please let me know if you have any questions or run into any problems while creating or updating your submission.
Thank you very much for working with us.
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: