-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowflake Connector Version 2 Updates #3270
Conversation
Fix for HTTP 500 error
Added User-Agent header and updated connection parameters
Updated Audience URL with space holder Added Connection credentials information
Added Covert action and updated schema
Updates from Karthik
Minor updates in Regex Datatype update in schema
Updating the account regex to make it generic subdomain pattern
Adding 500 status code for Convert function
Updated regex validation for instance url
Updated schema for GetResults Updated regex validation
Updating escape sequence in regex
Updated readme.md
Update readme.md
Fixed review comments about step C
Updated redireceMode as GlobalPerConnector Updated redirectUrl as empty string Added clientId and clientSecret with default null value
Removed redirecturl
Adding snowflake v2 files
Updated the readme.md file to reflect the deprecated Snowflake connector.
Updated the readme.md file to reflect the deprecated Snowflake connector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @naisonslalom,
Could you please update readme.md file as per the template in the below path.
Update readme.md as per the template
Updated Readme as per the template
This reverts commit dd8acac.
Updated readme.md to fix the issues found in review
@vmanoharas, readme.md file is updated as per the template. Please review and let us know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @naisonslalom
I hope you are doing well.
Congratulations, your pull request is approved and merged. Please submit the files to ISV Studio or update your submission using your latest commit ID, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio. Please make sure that the icon meets all the requirements, that it’s size is 230x230, icon background is not white or transparent and it matches the iconBrandColor property in apiProperties.json file.
After making the submission in ISV Studio, please attach an intro.md file in the activity control section. This file is required and it's different from readme.md. You can find an example of intro.md file on this page at step 6.
Please Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector.
We expect all tests to be completed within 1-2 weeks.
If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions.
Please let me know if you have any questions or run into any problems while creating or updating your submission.
Thank you very much for working with us.
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: