-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowflake v2 bug fixes and refactoring Convert action #3670
Commits on Aug 8, 2024
-
- First pass at getting all partitions. Still needs a few parameters …
…setup so the code is currently broken. WIP.
Configuration menu - View commit details
-
Copy full SHA for 4fe3265 - Browse repository at this point
Copy the full SHA 4fe3265View commit details
Commits on Aug 13, 2024
-
Convert all partitions, not just the first one.
Configuration menu - View commit details
-
Copy full SHA for fd85b8f - Browse repository at this point
Copy the full SHA fd85b8fView commit details -
Fix placeholders of querystring params that need gotten/set for fetching subsequent partitions.
Configuration menu - View commit details
-
Copy full SHA for 0387027 - Browse repository at this point
Copy the full SHA 0387027View commit details
Commits on Aug 19, 2024
-
Fix syntax errors to ensure that isn't why connector upload is failing.
Configuration menu - View commit details
-
Copy full SHA for 7db5142 - Browse repository at this point
Copy the full SHA 7db5142View commit details
Commits on Aug 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e1ca0a8 - Browse repository at this point
Copy the full SHA e1ca0a8View commit details -
Wanted a record of the fact that these changes are still returning subsequent partitions in array format, despite literally every response being converted. Is there maybe some sort of caching of the connector behavior, because it seems like I can't ever get the behavior of my data flow to change at all...
Configuration menu - View commit details
-
Copy full SHA for 4d4febb - Browse repository at this point
Copy the full SHA 4d4febbView commit details -
This version of the connector is the most complete example that can successfully be uploaded as a custom connector. Yet I still can't get the behavior to change no matter what code changes I make.
Configuration menu - View commit details
-
Copy full SHA for 3eaefe8 - Browse repository at this point
Copy the full SHA 3eaefe8View commit details
Commits on Aug 22, 2024
-
Issue #5 - Null detection and Type Conversion Error (#1)
* Update script.csx - Fix null detection. * Fix issue with null handling in Snowflake connector --------- Co-authored-by: jbrinkman <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aab7e25 - Browse repository at this point
Copy the full SHA aab7e25View commit details -
Update apiDefinition.swagger.json
- This version of the swaggerjson SHOULD be working, but we are seeing the DataSchema object being flattened out once uploaded to customer connector.
Configuration menu - View commit details
-
Copy full SHA for f4f5107 - Browse repository at this point
Copy the full SHA f4f5107View commit details -
Got the swagger right (was really the code was had checked in before with just a little cleanup. The custom connector is now failing due to internal server error so we need to find a way to use the test page in powerapps online, despite the fact that it doesn't really handle array data very well. Possibly specifying the raw body data might be a workaround.
Configuration menu - View commit details
-
Copy full SHA for ed22c98 - Browse repository at this point
Copy the full SHA ed22c98View commit details -
- Last few tweaks to get the customer connector to return subsequent partitions in pre-converted format.
Configuration menu - View commit details
-
Copy full SHA for c738294 - Browse repository at this point
Copy the full SHA c738294View commit details
Commits on Aug 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 38377bc - Browse repository at this point
Copy the full SHA 38377bcView commit details -
- extra body element is required. Caused a whole mess of issues. - change DataSchema to required and deprecate or delete unused endpoints as needed. - Remove fetchAllPages feature and separate into its own branch.
Configuration menu - View commit details
-
Copy full SHA for 74c7ad6 - Browse repository at this point
Copy the full SHA 74c7ad6View commit details -
- Make log messages more accurate. - Remove last remnant of fetchAllPartitions.
Configuration menu - View commit details
-
Copy full SHA for 7081327 - Browse repository at this point
Copy the full SHA 7081327View commit details -
Merge pull request #2 from Bit-Quill/jbrinkman_VersionInfo
Add version information into readme documentation
Configuration menu - View commit details
-
Copy full SHA for 9e6b2a9 - Browse repository at this point
Copy the full SHA 9e6b2a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cd349f - Browse repository at this point
Copy the full SHA 6cd349fView commit details -
Configuration menu - View commit details
-
Copy full SHA for df01092 - Browse repository at this point
Copy the full SHA df01092View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1601c27 - Browse repository at this point
Copy the full SHA 1601c27View commit details -
Merge pull request #3 from Bit-Quill/tchee_Partitions
SPC-12/SPC-32 - All partitions should be returned in json class notation.
Configuration menu - View commit details
-
Copy full SHA for 31fde79 - Browse repository at this point
Copy the full SHA 31fde79View commit details
Commits on Aug 29, 2024
-
- The code is acting absolutely insane and returning GetResults method as just a single property "Data" formatted as array. Since this is the 0 partition it should include metadata. - The interface is also not showing the partition parameter for the execsql method, so something is borked.
Configuration menu - View commit details
-
Copy full SHA for 5840936 - Browse repository at this point
Copy the full SHA 5840936View commit details
Commits on Aug 30, 2024
-
GetResults partition zero fixed
- This was a very subtle issue related to the fact that when you call GetResults operation for partition zero you have no request body, so it cannot be parsed as json. - Change the response of execstmt async to match the schema of the sync version b/c the powerapps ui does not seem to be able to deal with the fact that async/sync have different response formats respectively.
Configuration menu - View commit details
-
Copy full SHA for 78402e2 - Browse repository at this point
Copy the full SHA 78402e2View commit details
Commits on Sep 3, 2024
-
Merge pull request #4 from Bit-Quill/tche_AsyncTimeout
Fix Async always erroring out
Configuration menu - View commit details
-
Copy full SHA for 8eeef21 - Browse repository at this point
Copy the full SHA 8eeef21View commit details
Commits on Sep 10, 2024
-
SPC-36: Handle unexpected async responses better (#5)
* Update script.csx - Fix async detection based on response code instead of request params, b/c apparently snowflake API can decide to return an async response if a synchronous response takes too long to return. * Fix typo in script.csx "BeginFetch" misspelled --------- Co-authored-by: Joseph Brinkman <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3f2502e - Browse repository at this point
Copy the full SHA 3f2502eView commit details
Commits on Sep 11, 2024
-
SPC-39: MULTI_STATEMENT_COUNT parameter was being ignored (#6)
* Update apiDefinition.swagger.json - change parameter name case to match snowflake docs exactly * add StatementHandles Map new response property for multi-statement handling. * Apply mappings to GetResults Same statementHandles mapping that was previously added to ExecSql was applied to GetResults to support Async * Remove async fixes These changes are already in dev branch, it was just a temporary change for debugging.
Configuration menu - View commit details
-
Copy full SHA for 7a33e8f - Browse repository at this point
Copy the full SHA 7a33e8fView commit details
Commits on Sep 17, 2024
-
Innacurate schema was causing compilation issues in the power apps. Better to leave it as a untyped object since the schema is dynamic.
Configuration menu - View commit details
-
Copy full SHA for 45c6720 - Browse repository at this point
Copy the full SHA 45c6720View commit details
Commits on Sep 19, 2024
-
- Parse Object/Array types (#8)
They were represented as a string before.
Configuration menu - View commit details
-
Copy full SHA for 0146734 - Browse repository at this point
Copy the full SHA 0146734View commit details
Commits on Sep 24, 2024
-
Document limitations per my experience. (#9)
* Document limitations per my experience. * - Tweak readme * Update language limitations in the Readme documentation. --------- Co-authored-by: jbrinkman <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2856664 - Browse repository at this point
Copy the full SHA 2856664View commit details
Commits on Sep 27, 2024
-
openapi spec validation errors (#10)
I was able to type the untyped objects, but a lot of those openapi spec validation errors are inherent to the fact that the snowflake api routes are technically all partial matches for eachother since the exec stmt path is "/"
Configuration menu - View commit details
-
Copy full SHA for db3b2db - Browse repository at this point
Copy the full SHA db3b2dbView commit details
Commits on Sep 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1d170f4 - Browse repository at this point
Copy the full SHA 1d170f4View commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 75e550f - Browse repository at this point
Copy the full SHA 75e550fView commit details