Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IronDefense custom connector for certification #969

Merged
merged 3 commits into from
Aug 16, 2021
Merged

Add IronDefense custom connector for certification #969

merged 3 commits into from
Aug 16, 2021

Conversation

marcus-defazio
Copy link
Contributor

@marcus-defazio marcus-defazio commented Jul 16, 2021 •
edited
Loading

When submitting a connector, please check the following conditions for your PR to ensure a smooth certification process.

  • I attest that the connector works and I verified by deploying and testing all the operations.
  • Independent Publisher Connectors Only: Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • ndependent Publisher Connectors Only: Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

@marcus-defazio marcus-defazio requested a review from a team as a code owner July 16, 2021 19:34
@marcus-defazio
Copy link
Contributor Author

I'm getting the following error when trying to validate with paconn validate

400 Client Error: Bad Request for url: https://api.powerapps.com/providers/Microsoft.PowerApps/objectIds/84acc217-96d2-4a95-b1a1-a772a05db2fc/validateApiSwagger?api-version=2016-11-01&enableConnectorCertificationRules=true

I'm not sure if this is an issue on my end or yours.

@sriyen-msft
Copy link
Contributor

@marcus-defazio I'm just checking in to see how things are going with updating your connector artifacts as per the given feedback. Please feel free to reach out with any questions you may have, Thanks.

1 similar comment
@sriyen-msft
Copy link
Contributor

@marcus-defazio I'm just checking in to see how things are going with updating your connector artifacts as per the given feedback. Please feel free to reach out with any questions you may have, Thanks.

@sriyen-msft sriyen-msft added the Validation phase Connector is being validated by Microsoft. label Aug 3, 2021
@marcus-defazio
Copy link
Contributor Author

I've addressed all the PR comments so far. Let me know if there's anything else!

sriyen-msft
sriyen-msft requested changes Aug 3, 2021
View reviewed changes
certified-connectors/IronDefense/apiDefinition.swagger.json Outdated
"security": [
{
"basic": [],
"jwt": []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcus-defazio Sorry for the late find - I have never seen this property, can you please let us know what is the use this property ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added when we generated our swagger file from our API code. I can remove it if you want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to make any changes @sriyen-msft ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added when we generated our swagger file from our API code. I can remove it if you want.

Please remove it to make sure it would not affect anything

@sriyen-msft sriyen-msft added needs:attention Needs attention from Microsoft or community needs:partner-attention and removed needs:attention Needs attention from Microsoft or community Validation phase Connector is being validated by Microsoft. labels Aug 7, 2021
@sriyen-msft sriyen-msft merged commit f98cca2 into microsoft:dev Aug 16, 2021
joshuaapple pushed a commit to docjuris/PowerPlatformConnectors that referenced this pull request Oct 6, 2021
@marcus-defazio @joshuaapple
Add IronDefense custom connector for certification (microsoft#969)
9bb05f8 
* add IronDefense connector files for certification

* address PR comments

* remove jwt prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriyen-msft sriyen-msft sriyen-msft approved these changes

Assignees
No one assigned
Labels
certified-connector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcus-defazio @sriyen-msft