-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting ImageResizer code base with code analysis #1041
Comments
@ryanbodrug-microsoft i did a push, think i got all warnings, however the tests don't want to seem to actually run. we also should mimic the clang stuff we're doing in the main repo assign to whomever. |
xref #53 |
@crutkas It looks like the unit tests weren't running as the xunit.runner.visualstudio NuGet package wasn't added to the project dependencies, and Visual Studio doesn't run xunit tests unless this adapter is installed. Adding it results in all the tests passing on the initial version of the code. I'll verify if they pass after the changes that were made above. Edit: They pass in the latest version as well if the same change is made. Should I push the changes in the .csproj file to this branch directly or through a pull request? |
Just check it in to that branch right now. We will do a more formal review for the actual module integration |
@crutkas The clangformat file gets automatically detected by Visual Studio if it is in the same git source tree. I've formatted the files in ShellExtensions using the clang file. All unit tests pass as well. |
@arjunbalgovind is there a way to suppress them with that reasoning? I know in c# you can for code analysis |
|
Suppressed those warnings using the |
Where is the associated PR? |
@crutkas I checked in the changes directly to the dev/imageResizer branch. Should I revert my last few commits and add it as a PR to this branch instead? |
you should be in the imageResizer branch, i just expected work to come in as a PR so the work has review. If Ryan or someone reviewed it, I'm good. |
Discussed with Ryan, he will be reviewing the changes offline. I'll make sure to use PRs for all future changes. |
https://github.com/microsoft/PowerToys/tree/dev/imageResizer
The text was updated successfully, but these errors were encountered: