[Update check] behavior when checking manually

[htcfreek]

Environment

Windows build number: 10.0.18363.778
PowerToys version: 17.0
PowerToy module for which you are reporting the bug (if applicable): settings

Steps to reproduce

1. Open general settings
2. Click "Check for Updates"

Expected behavior

Toast notification with one of the following messages:

• No update available.
• Update available. Download started./Update downloading with progress bar.
• Update available. Visit Github page.

Actual behavior

Github page is opening.

[htcfreek]

We could also add a link to our Github project page between button and the link "Report a bug".

=> This is tracked by issue #2688.

[htcfreek]

How the manually update process could work:

[htcfreek]

@enricogior
Should we add this to v1.0 step?

[enricogior]

Done. Thanks.

[htcfreek]

@enricogior
Do we need some labels to ad. I hav not the permissions to do that.

Have seen that the label exists.

[MinhThienDX]

Can we skip the question "Update ready. Install?" when auto-update?
I just using my pc and the app ask me to install update.
I think it should auto install update when the user did not check for update.
And after installing, I think it should run itself, not exit.

In summary, I think auto-update should do 4 things:

1. Auto check for update
2. Auto download update
3. Auto install update without prompt (this is not working currently on v0.18 running as User)
4. After install, auto start PowersToy (I know we can't start after install currently)

[htcfreek]

@SeraphimaZ
Nice work in the PR.

One Idea for the PR:

1. Can we show the Version in the progress title of the "download..." toast like PowerToys Update v18.0.2?

[SeraphimaZykova]

1. Can we show the Version in the progress title of the "download..." toast like PowerToys Update v18.0.2?

Sure. If I got it right, toast should look like this? And 0.18.2 here is the version that is downloaded?

[htcfreek]

"@htcfreek, when update is ready to install. There are 3 options: 'Update now', 'At next launch', 'Abort'."
Originally posted by @SeraphimaZ in #4385 (comment)

@SeraphimaZ
Don't know if it make sense to download and the ask if the user wants to abort.
I think then we should ask before downloading or allow the abortion of the download. Because if the user abort the install after the download, we have unnecessarily downloaded PT.

[SeraphimaZykova]

I think then we should ask before downloading or allow the abortion of the download. Because if the user abort the install after the download, we have unnecessarily downloaded PT.

That makes sense, I'll add notification with choices 'Download' or 'Abort' before downloading, thank you.

Also, I think that it's not obvious that Download updates automatically switch value is related to Check for updates button functionality. In my opinion Download updates automatically is about background processes, and button user will use when he wants update right now. Besides that there is a link to releases page above the Check for updates button. So maybe would be better to keep only downloading functionality and remove notification with a link to the github page.

[htcfreek]

Also, I think that it's not obvious that Download updates automatically switch value is related to Check for updates button functionality. In my opinion Download updates automatically is about background processes, and button user will use when he wants update right now. Besides that there is a link to releases page above the Check for updates button. So maybe would be better to keep only downloading functionality and remove notification with a link to the github page.

Yes you are right. But what will we then do if the user has no admin rights and we can't install. Maybe we can the show a message like this:

⚠️ Installation failed
Installation is not possible. You have no admin rights. Please install manually.

<Open Setup Folder>

Or we can have the UAC showing to elevate the installation.

[htcfreek]

@SeraphimaZ
I have two thoughts about the notification "download update? - yes/no":

1. We should show the update path as version number like in the "ready to install" notification.
2. I know that we can check if the internet connection is marked as metered. Maybe we can then add under the version numbers the following information text: ⚠️ Your internet connection is marked as metered.

Preview:

🖼️ PowerToys

An update for PowerToys is available for
download and installation.
v18.0.1 -> v18.0.2

⚠️ Your internet connection is marked
as metered.

[Download]     [Abort]

[htcfreek]

Collecting the ideas from @SeraphimaZ, @enricogior (see PR) and me, we would get the following behaviour at the moment:

1. When the user clicks on the "search for updates" button:

• If no update is available show "no update" notification.
• If update is available show the "update available for download and install" notify with metered connection hint, version numbers, "update" button and "more info" button.

2. User clicks on "Update":

• Showing "Download status".
• Download the update.
• Start install.

3. If install exit:

• PT shows update successful.
• On failure: Show "update failed" notify with "download folder" button.

@enricogior, @SeraphimaZ: Is this okay for you or what do you think about?

@enricogior
Did the setup asks automatically for elevation if the user has not the necessary rights? Then we don't need the "Download folder button" thing.

[crutkas]

Fixed in 0.19.0, please visit https://github.com/microsoft/PowerToys/releases/ for the latest release