Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings V2 UX] Improve logical groupings of the general page #2688

Closed
niels9001 opened this issue May 5, 2020 · 24 comments
Closed

[Settings V2 UX] Improve logical groupings of the general page #2688

niels9001 opened this issue May 5, 2020 · 24 comments
Assignees
Labels
Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@niels9001
Copy link
Contributor

niels9001 commented May 5, 2020

The current General settings page could use some improved structure for the various settings as discussed in #2676.

Here's a proposal:

Running as .. (Title)

  • Always run as administrator..... (Checkbox)
  • Run at startup (Checkbox)
  • Restart as admin (Button)

Appearance (Title)

  • Choose settings color (Radiobutton group)

About PowerToys (Title) (In the side panel)

  • Version x.xx.x (clickable link to release notes)

  • Download updates automatically (Checkbox)

  • Check for updates (Button)

  • Various links

@htcfreek Please add your proposal of splitting the update section. I like that idea.

@htcfreek
Copy link
Collaborator

htcfreek commented May 5, 2020

@niels9001 Do you know a WYSIWYG-Editor for XAML/WinUi3?

@niels9001
Copy link
Contributor Author

You could try Blend (it comes with Visual Studio), but most WYSIWYG editors won't give you code that's of high quality imo. Or you can try one of the toolkits for various design tools (e.g. Figma, Sketch or Adobe XD) but that won't give you code obviously.

@htcfreek
Copy link
Collaborator

htcfreek commented May 5, 2020

In the following pictures you can see my proposal on the structure of the general settings page.
I did my best to respect the Guidlines for app settings.

Some of the ideas are my own and the other ideas are based on the issues #1482, #889, #964, #2354 and the comment form @niels9001 in this issue.
The idea adding a link to the privacy settings is stolen from the MS Edge settings. 😉

👉 The setting "Check for updates automatically" is not implemented in PT at the moment. But I think we should implement them.
👉 The link to the Github project page is not implemented at the moment. But I think we should implement it.

Settings run as user & system telemetry off

image
Mock up image generated with MS Word and screenshots.

Settings run as administrator & system telemetry on

image
Mock up image generated with MS Word and screenshots.

@niels9001
Copy link
Contributor Author

Nice, I like this!

My thoughts:

  • We have a ' Learn about Admin mode' button in the latest build-features branch. I'd add that under the Restart as Admin button.
  • What are your thoughts around the 'Check for updates automatically' option? By default the app already does this, right? Not sure why we would like to disable this option, it could result in users being stuck on (very) old versions simply because they forgot to check manually?
  • I like the addition of adding a link to the GitHub read me. Maybe we can add a oneliner to point out the fact that this tool is open source?

@laviusmotileng-ms What are your thoughts?

@niels9001 niels9001 changed the title [Settings V2 UX] Improve groupings of various features [Settings V2 UX] Improve logical groupings of the general page May 5, 2020
@htcfreek
Copy link
Collaborator

htcfreek commented May 5, 2020

We have a ' Learn about Admin mode' button in the latest build-features branch. I'd add that under the Restart as Admin button.

Why as button? I think a link would be better and more standardized.
The link could be shown betwen User Informationen and Restart Button. But only if PT is running as user.

What are your thoughts around the 'Check for updates automatically' option? By default the app already does this, right? Not sure why we would like to disable this option, it could result in users being stuck on (very) old versions simply because they forgot to check manually?

For example if PT is installed in companys on clients or servers, where the user had no rights to install software and the software gets updated by SCCM or other tools. (For this scenario normal users shouldn't be able to change the sittings.)
An other scenario would be an user who wants to check only manually every x days.

I like the addition of adding a link to the GitHub read me. Maybe we can add a oneliner to point out the fact that this tool is open source?

Great idea. I like it.
We should add this in the sidebar. We could have this in the "related links" section as a link to https://de.m.wikipedia.org/wiki/Open_Source.

@niels9001
Copy link
Contributor Author

Yep.. that's what I meant with 'button', a 'learn more' HyperlinkButton ;).

Right, I see - you might want to start a new issue for that. Please add the context you just described there as the 'user need'.

I think the oneliner only needs to describe the fact that this project is open source. The button could lead to this repo (with maybe a label like 'Contribute to this project' or something like that :)!

@enricogior
Copy link
Contributor

For example if PT is installed in companys on clients or servers, where the user had no rights to install software and the software gets updated by SCCM or other tools. (For this scenario normal users shouldn't be able to change the sittings.)
An other scenario would be an user who wants to check only manually every x days.

These type of choices need to be reviewed, please consult with @crutkas before making any change.

@htcfreek
Copy link
Collaborator

htcfreek commented May 5, 2020

For example if PT is installed in companys on clients or servers, where the user had no rights to install software and the software gets updated by SCCM or other tools. (For this scenario normal users shouldn't be able to change the sittings.)
An other scenario would be an user who wants to check only manually every x days.

These type of choices need to be reviewed, please consult with @crutkas before making any change.

I have mentioned @crutkas in the new issue.

@niels9001 niels9001 self-assigned this May 6, 2020
@niels9001 niels9001 added the Product-Settings The standalone PowerToys Settings application label May 6, 2020
@htcfreek
Copy link
Collaborator

htcfreek commented May 7, 2020

I have updated my mock ups to

  • be more in line with the official settings app.
  • add some missing elements.
  • make some small text changes.

👉 Link to window's feedback settings: ms-settings:privacy-feedback
👉 On black theme the red lable must be yellow.

[Update 2020-05-07 22:43] Fixed some text mistakes in the mock up and changed the layout of the open source notice.
[Update 2020-05-07 23:12] Added info about metered connections.

Settings run as user & system telemetry off

PT-General_settings_V2-2-001

Settings run as administrator & system telemetry on

PT-General_settings_V2-2-002

@mdtauk
Copy link

mdtauk commented May 7, 2020

Are you applying an order of importance to these layouts. Common and important settings at the top.

There is a SystemErrorText ThemeResource you can use so the text is Red in Light and Yellow in Dark

@htcfreek
Copy link
Collaborator

htcfreek commented May 7, 2020

Are you applying an order of importance to these layouts. Common and important settings at the top.

I think is the best order in relation to how important the settings are. But I am free for other ideas.

Please have in mind that these are only image mock ups.

There is a SystemErrorText ThemeResource you can use so the text is Red in Light and Yellow in Dark

Great tipp.

@niels9001
Copy link
Contributor Author

Is the Telemetry options in the spec? Not seeing it in the latest build-features?

@htcfreek
Copy link
Collaborator

htcfreek commented May 7, 2020

Is the Telemetry options in the spec? Not seeing it in the latest build-features?

See #964.

@htcfreek
Copy link
Collaborator

htcfreek commented May 7, 2020

img

@niels9001
I think we should have the "Learn more about admin mode" under the setting "Always run as administrator" and should don't hide them. Then the users can read about it before enabling the setting "Always run as administrator".
What du you think?

@niels9001
Copy link
Contributor Author

@crutkas @laviusmotileng-ms

Do you agree (for the settings that we have at the moment)?

Should be a minor task with just some XAML changes. I can pick this up.

@crutkas
Copy link
Member

crutkas commented May 9, 2020

Go nuts

@htcfreek
Copy link
Collaborator

htcfreek commented May 9, 2020

@niels9001
If we change the color setting into a dropdown/select menu button, we should do this on all settings pages, to have the same look and feel everywhere.
I am not shure about which pages are affect. It could be good to have a seperate issue for that.

@niels9001
Copy link
Contributor Author

I'd stick to the radiobuttons since it reduces cognitive load (vs. combobox) since there are only 3 options (that we won't extend). And it is inline with how the W10 Settings app does it.

Nice background info:
“Radio Buttons UX Design” by Nick Babich https://link.medium.com/8Ato02qql6

@htcfreek
Copy link
Collaborator

htcfreek commented May 9, 2020

I'd stick to the radiobuttons since it reduces cognitive load (vs. combobox) since there are only 3 options (that we won't extend). And it is inline with how the W10 Settings app does it.

The default without choosing "Custom" is only a dropdown field.
See https://winaero.com/blog/wp-content/uploads/2018/11/Windows-10-Choose-Color-Mode-_.png

@htcfreek
Copy link
Collaborator

htcfreek commented May 10, 2020

@crutkas Whats your thoughts about the following ideas/changes for the general page?

General settings page > Updates

  • We should add a text hint that auto download only works when running in admin mode and not using a metered connection.
  • User should not be able to change auto download setting when PT run as user and then setting then must be disabled. (Show the auto update option to admin users only #2354)
  • If the setting is disabled we should have the hint "Only available when running as admin." in a seperate line above caption and control (see Guidlines), without brackets and in red/yellow.
  • What about having a seperate "Release Notes" link under the "check update" button instead having the number as link? - That would look more like official settings app.
    image

General settings page > Side panel

  • What about split side pannel in three sections:

About PowerToys
PowerToys is open source software.
Learn more
Github project page

We collect Telemetry data.
But we respect your privacy.
Privacy statement

Request a feature
Report a Bug

@htcfreek
Copy link
Collaborator

@crutkas Whats your thoughts about the following ideas/changes for the general page?

General settings page > Updates

  • We should add a text hint that auto download only works when running in admin mode and not using a metered connection.
  • User should not be able to change auto download setting when PT run as user and then setting then must be disabled. (Show the auto update option to admin users only #2354)
  • If the setting is disabled we should have the hint "Only available when running as admin." in a seperate line above caption and control (see Guidlines), without brackets and in red/yellow.
  • What about having a seperate "Release Notes" link under the "check update" button instead having the number as link? - That would look more like official settings app.
    image

General settings page > Side panel

  • What about split side pannel in three sections:

About PowerToys
PowerToys is open source software.
Learn more
Github project page

We collect Telemetry data.
But we respect your privacy.
Privacy statement

Request a feature
Report a Bug

@crutkas Can you please give us a feedback on this. Especially the about section changes. Thank you.

@htcfreek
Copy link
Collaborator

htcfreek commented May 11, 2020

@niels9001
What about changing the toggle switch title "Download updates automatically" to "Download updates automatically when running with administrativ permission and I don't use a metered internet connection"? Then the user knows everything what is important and we don't need an explanation text under the toggle switch?

Moved to the issue that we can discuss it here!

@crutkas
Copy link
Member

crutkas commented May 11, 2020

@htcfreek, Lets pause and have single items here. We are going to merge the main item here. This issue will be closed out for the the pending PR.

At this point, tweaks should be individual tracked issues so they can be discussed at their own merit.

Single issue, single topic, single PR

@crutkas crutkas added the Status-In progress This issue or work-item is under development label May 11, 2020
@crutkas crutkas added this to the Build 2020 milestone May 11, 2020
@crutkas crutkas added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels May 11, 2020
@htcfreek
Copy link
Collaborator

@htcfreek, Lets pause and have single items here. We are going to merge the main item here. This issue will be closed out for the the pending PR.

At this point, tweaks should be individual tracked issues so they can be discussed at their own merit.

Single issue, single topic, single PR

@crutkas, @niels9001
I will create the issues later and we can merge the existing PR if no critical changes needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

5 participants