Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mouse Jump] - reduce dependency on WinForms utility classes #25482

Closed
mikeclayton opened this issue Apr 13, 2023 · 1 comment
Closed

[Mouse Jump] - reduce dependency on WinForms utility classes #25482

mikeclayton opened this issue Apr 13, 2023 · 1 comment
Labels
Idea-Enhancement New feature or request on an existing product Product-Mouse Utilities Refers to the Mouse Utilities PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@mikeclayton
Copy link
Contributor

mikeclayton commented Apr 13, 2023 •
edited
Loading

Description of the new feature / enhancement

Mouse Jump currently uses WinForms as the Presentation Framework, but it's also using some of the bundled utility classes for its core functionality (e.g. Screens to get screen dimensions, Cursor to move the mouse pointer) which would make it difficult to port to a different Presentation Framework (e.g. WPF or WinUI3).

I've been working on replacing the use of the following classes with native Win32 calls (using CsWin32 bindings as a starting point):

  • System.Windows.Forms.Cursor
  • System.Windows.Forms.Screen
  • System.Windows.Forms.SystemInformation

I'll open a PR with my changes shortly...

Scenario when this would be used?

General maintenance - would make it easier to move to a different Presentation Framework.

Supporting information

No response
@mikeclayton mikeclayton added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Apr 13, 2023
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Apr 13, 2023
@mikeclayton
[Mouse Jump] - reorganise existing NativeMethods (microsoft#25482)
ad31917
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Apr 13, 2023
@mikeclayton
[Mouse Jump] Merge branch 'main' into dev/mikeclayton/mouse-jump (mic…
6b7788b 
…rosoft#25482)
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Apr 13, 2023
@mikeclayton
Mouse Jump] - reorganise Helper classes / main form code (microsoft#2…
c474a9e 
…5482)
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Apr 13, 2023
@mikeclayton
Mouse Jump] - replace use of System.Windows.Forms.Screen with Native …
a9e166a 
…Methods (microsoft#25482)
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Apr 13, 2023
@mikeclayton
Mouse Jump] - replace use of System.Windows.Forms.SystemInformation w…
df70a09 
…ith Native Methods (microsoft#25482)
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Apr 13, 2023
@mikeclayton
[Mouse Jump] - replace use of System.Windows.Forms.Cursor with Native…
d0489ae 
… Methods (microsoft#25482)
@mikeclayton mikeclayton mentioned this issue Apr 13, 2023
Merged
15 tasks
@Aaron-Junker Aaron-Junker added Idea-Enhancement New feature or request on an existing product Status-In progress This issue or work-item is under development Product-Mouse Utilities Refers to the Mouse Utilities PowerToy labels Apr 14, 2023
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Apr 18, 2023
jaimecbernardo pushed a commit that referenced this issue Apr 24, 2023
@mikeclayton
[MouseJump]Reduce winforms dependency, thumbnail size settings, short…
fda75e4 
…cut keys(#25487)

* [Mouse Jump] - reorganise existing NativeMethods (#25482)

* Mouse Jump] - reorganise Helper classes / main form code (#25482)

* Mouse Jump] - replace use of System.Windows.Forms.Screen with Native Methods (#25482)

* Mouse Jump] - replace use of System.Windows.Forms.SystemInformation with Native Methods (#25482)

* [Mouse Jump] - replace use of System.Windows.Forms.Cursor with Native Methods (#25482)

* [Mouse Jump] - improve popup responsiveness (#25484)

* [Mouse Jump] - fixed spellchecker errors (#25484)

* [Mouse Jump] - add settings card for thumbnail size (#24564)

* [Mouse Jump] - shortcut keys to jump to centres of screens (#25069)

* [Mouse Jump] - fix spelling (#25069)

* [Mouse Jump] - fix spelling - numpad (#25069)

* [Mouse Jump] - updated "thumbnail size" settings text (#24564)
@jaimecbernardo jaimecbernardo added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels May 15, 2023
@jaimecbernardo
Copy link
Collaborator

This has been shipped for 0.70.0. Please updated to the latest release. Thank you.

BLM16 pushed a commit to BLM16/PowerToys that referenced this issue Jun 22, 2023
@mikeclayton @BLM16
[MouseJump]Reduce winforms dependency, thumbnail size settings, short…
5418715 
…cut keys(microsoft#25487)

* [Mouse Jump] - reorganise existing NativeMethods (microsoft#25482)

* Mouse Jump] - reorganise Helper classes / main form code (microsoft#25482)

* Mouse Jump] - replace use of System.Windows.Forms.Screen with Native Methods (microsoft#25482)

* Mouse Jump] - replace use of System.Windows.Forms.SystemInformation with Native Methods (microsoft#25482)

* [Mouse Jump] - replace use of System.Windows.Forms.Cursor with Native Methods (microsoft#25482)

* [Mouse Jump] - improve popup responsiveness (microsoft#25484)

* [Mouse Jump] - fixed spellchecker errors (microsoft#25484)

* [Mouse Jump] - add settings card for thumbnail size (microsoft#24564)

* [Mouse Jump] - shortcut keys to jump to centres of screens (microsoft#25069)

* [Mouse Jump] - fix spelling (microsoft#25069)

* [Mouse Jump] - fix spelling - numpad (microsoft#25069)

* [Mouse Jump] - updated "thumbnail size" settings text (microsoft#24564)
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue May 10, 2024
@mikeclayton
[Mouse Jump] - move code shared with FancyMouse into "Common" folder (m…
d22e07e 
…icrosoft#25482)
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue May 10, 2024
@mikeclayton
[Mouse Jump] - updates to NativeMethods (microsoft#25482)
61a59ce
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue May 10, 2024
@mikeclayton
[Mouse Jump] - added new drawing / layout / style classes (microsoft#…
9854c33 
…25482)
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue May 10, 2024
@mikeclayton
[Mouse Jump] - new style-based preview rendering (actual preview visu…
a451b15 
…al style unchanged) (microsoft#25482)
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue May 12, 2024
@mikeclayton
[Mouse Jump] - add words to spell checker (microsoft#25482)
6a5a3a2
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue May 12, 2024
@mikeclayton
[Mouse Jump] - small tweak to error handling (microsoft#25482)
9747899
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue May 12, 2024
@mikeclayton
[Mouse Jump] - fixed failing test (microsoft#25482)
c032b0b
jaimecbernardo pushed a commit that referenced this issue Jun 12, 2024
@mikeclayton
[MouseJump]Refactor code to allow later introduction of customizable …
651f2e4 
…appearance (#32838)

* [Mouse Jump] - move code shared with FancyMouse into "Common" folder (#25482)

* [Mouse Jump] - updates to NativeMethods (#25482)

* [Mouse Jump] - added new drawing / layout / style classes (#25482)

* [Mouse Jump] - new style-based preview rendering (actual preview visual style unchanged) (#25482)

* [Mouse Jump] - add words to spell checker (#25482)

* [Mouse Jump] - small tweak to error handling (#25482)

* [Mouse Jump] - fixed failing test (#25482)
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jun 23, 2024
@mikeclayton
[Mouse Jump] - moved "common" code into new library so it can be refe…
22d7cdb 
…renced by SettingsUI - microsoft#25482
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jun 23, 2024
@mikeclayton
[Mouse Jump] - deleted a few redundant classes - microsoft#25482
b8ce5b5
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jun 26, 2024
@mikeclayton
[Mouse Jump] - change to static desktop image in settings ui - micros…
3fc1699 
…oft#25482
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jun 26, 2024
@mikeclayton
[Mouse Jump] - fixing build - microsoft#25482
c71c1ce
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jun 28, 2024
@mikeclayton
[Mouse Jump] - fixing build - microsoft#25482
269ce53
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jun 29, 2024
@mikeclayton
[Mouse Jump] - trying to fix build (add RuntimeIdentifiers per Awake) -
3a69f40 
microsoft#25482
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jun 29, 2024
@mikeclayton
[Mouse Jump] - trying to fix build (<UseWindowsForms> -> true) - micr…
57009c0 
…osoft#25482
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jun 30, 2024
@mikeclayton
[Mouse Jump] - trying to fix build (remove system.drawing.common) - m…
9a16593 
…icrosoft#25482
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jun 30, 2024
@mikeclayton
[Mouse Jump] - trying to fix build (remove <UseWindowsForms>) - micro…
c7f48c4 
…soft#25482
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jun 30, 2024
@mikeclayton
[Mouse Jump] - trying to fix build (re-adding System.Drawing.Common) - …
d84d073 
…microsoft#25482
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jul 1, 2024
@mikeclayton
[Mouse Jump] - reverting changes - microsoft#25482
2f24515
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jul 29, 2024
@mikeclayton
[Mouse Jump] - adding predefined "preview types" to settings ui - mic…
9442d29 
…rosoft#25482
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jul 29, 2024
@mikeclayton
[Mouse Jump] - fixing spell-checker - microsoft#25482
11098cc
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jul 29, 2024
@mikeclayton
[Mouse Jump] - fixing xaml formatting - microsoft#25482
cacff25
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Jul 29, 2024
@mikeclayton
[Mouse Jump] - use MSTest package - microsoft#25482
3f1c890
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Aug 5, 2024
@mikeclayton
[Mouse Jump] - fixing mouse jump settings ui - microsoft#25482
4782f1b
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Aug 6, 2024
@mikeclayton
[Mouse Jump] - fixing shimmer in preview image size - microsoft#25482
437ef32
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Aug 6, 2024
@mikeclayton
[Mouse Jump] - fixing xaml formatting - microsoft#25482
0ff65a3
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Aug 7, 2024
@mikeclayton
[Mouse Jump] - centering preview image, resource strings - microsoft#…
185b7ab 
…25482
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Aug 7, 2024
@mikeclayton
[Mouse Jump] - fixing merge conflict - microsoft#25482
f33d5d0
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Aug 7, 2024
@mikeclayton
[Mouse Jump] - fixing xaml formatting - microsoft#25482
2c23ae2
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Aug 7, 2024
@mikeclayton
[Mouse Jump] - added another resource string - microsoft#25482
a7e137c
mikeclayton added a commit to mikeclayton/PowerToys that referenced this issue Aug 8, 2024
@mikeclayton
[Mouse Jump] - more xaml formatting - microsoft#25482
d6c1966
mikeclayton pushed a commit to mikeclayton/PowerToys that referenced this issue Aug 17, 2024
[Mouse Jump] - moving common code to MouseJump.Common project - micro…
ba8b7cf 
…soft#25482
mikeclayton pushed a commit to mikeclayton/PowerToys that referenced this issue Aug 17, 2024
[Mouse Jump] - fixing warnings in MouseJump.Common - microsoft#25482
2fc1901
mikeclayton pushed a commit to mikeclayton/PowerToys that referenced this issue Aug 22, 2024
[Mouse Jump] - remove project type guids - microsoft#25482
f3b4a21
mikeclayton pushed a commit to mikeclayton/PowerToys that referenced this issue Aug 22, 2024
[Mouse Jump] - simplify mousejump *.csproj files - microsoft#25482
7fcc9ab
mikeclayton pushed a commit to mikeclayton/PowerToys that referenced this issue Aug 22, 2024
[Mouse Jump] - fixing broken tests - microsoft#25482
7ca44c7
mikeclayton pushed a commit to mikeclayton/PowerToys that referenced this issue Aug 22, 2024
[Mouse Jump] - fixing broken build - microsoft#25482
76c83f2
mikeclayton pushed a commit to mikeclayton/PowerToys that referenced this issue Aug 22, 2024
[Mouse Jump] - editing MouseJump.Common.UnitTests.csproj - microsoft#…
997dc13 
…25482
mikeclayton pushed a commit to mikeclayton/PowerToys that referenced this issue Aug 22, 2024
[Mouse Jump] - editing MouseJump.Common.csproj (UseWindowsForms=true) -
e9345d6 
microsoft#25482
mikeclayton pushed a commit to mikeclayton/PowerToys that referenced this issue Aug 22, 2024
[Mouse Jump] - fixing spellcheck - microsoft#25482
797a49b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Idea-Enhancement New feature or request on an existing product Product-Mouse Utilities Refers to the Mouse Utilities PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mikeclayton @crutkas @jaimecbernardo @Aaron-Junker