Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak "About PowerToys" in General settings tab into sections #2908

Closed
htcfreek opened this issue May 12, 2020 · 19 comments
Closed

Tweak "About PowerToys" in General settings tab into sections #2908

htcfreek opened this issue May 12, 2020 · 19 comments
Assignees
Labels
Area-User Interface things that regard UX for PowerToys Cost-Small Small work item - 0-8 hours of work Product-Settings The standalone PowerToys Settings application

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented May 12, 2020

In this issue I will take up my porposal from PR #2822 and issue #2688 to change the structure of the "About PowerToys" section in the side panel of general settings page.
I think the existing structure should be better sorted and can be supplemented by @niels9001 proposal of an open source info.

@crutkas What do you think about the proposed changes?

Proposal for structure

Now
(image source: #2822)
Proposal
(image source: screenshot of word document)
image image

👉 Seen after creating this issue: On the other settings pages we only have a link called "Give feedback". Should we change this in the General page to be in line with the other pages?

Link details

Link Destination
Learn more
(maybe "Open source notice")
Description about open source software in wiki or readme. / https://opensource.microsoft.com/codeofconduct/ / https://github.com/microsoft/PowerToys/blob/master/NOTICE.md
How to contribute https://github.com/microsoft/PowerToys#contributing
Github project page https://github.com/microsoft/PowerToys
Privacy statement https://github.com/microsoft/PowerToys#privacy-statement
Request a feature https://github.com/microsoft/PowerToys/issues/new?assignees=&labels=&template=feature_request.md&title=
Report a bug https://github.com/microsoft/PowerToys/issues/new?assignees=&labels=&template=bug_report.md&title=
@crutkas
Copy link
Member

crutkas commented May 12, 2020

I think it is a good idea. Too verbose. we need the open source notice as well.

  • Open source
  • Feedback
  • Notices

@crutkas crutkas changed the title [Settings v2] Restructure the "About PowerToys" section "About PowerToys" section May 12, 2020
@crutkas crutkas added Product-Settings The standalone PowerToys Settings application Area-User Interface things that regard UX for PowerToys labels May 12, 2020
@htcfreek
Copy link
Collaborator Author

htcfreek commented May 12, 2020

I think it is a good idea. Too verbose. we need the open source notice as well.

  • Open source
  • Feedback
  • Notices

I understood your comment so that we should only have one feedback link on the general page. Right?

What about the following structure:
Open source text
-> Learn more (Link to explanation)
-> Open source notice
-> How to contribute
-> Github project page

Privacy text
-> Privacy statement

-> Give feedback

@htcfreek
Copy link
Collaborator Author

htcfreek commented May 12, 2020

What about adding the feedback symbol in front of the feedback link name?
This is symbol character ED15 of the font Segoe MDL2 Assets.
image

More details on implementation in xaml:
https://docs.microsoft.com/en-us/windows/uwp/design/style/segoe-ui-symbol-font.

Maybe we need an extra issue for that.

@htcfreek
Copy link
Collaborator Author

Example image including the things form the last three comments:
About_01

@htcfreek
Copy link
Collaborator Author

@crutkas
Should we do the changes for 0.18 or for a later release?

@jyuwono jyuwono added this to the Suggested Ideas milestone May 13, 2020
@crutkas
Copy link
Member

crutkas commented May 13, 2020

this will not be in for 0.18. we're on final fixes and adjustments for that.

@crutkas crutkas modified the milestones: Suggested Ideas, v1.0 Release May 13, 2020
@htcfreek
Copy link
Collaborator Author

this will not be in for 0.18. we're on final fixes and adjustments for that.

Okay. But I think we should not wait a long time to implement it.

@htcfreek
Copy link
Collaborator Author

htcfreek commented May 29, 2020

When working on this issue we should

  • make sure the all "about module" sections have the same look and feel like the new "about PowerToys" section.
  • that we have the same elements on all "about module" sections: gif, overview link, give feedback link

@niels9001
Copy link
Contributor

@htcfreek I think 0.20 addresses some of these concerns (consistency for every module page). Agree?

@crutkas
Copy link
Member

crutkas commented Aug 7, 2020

I agree. Please ping if someone disagrees with this

@crutkas crutkas closed this as completed Aug 7, 2020
@htcfreek
Copy link
Collaborator Author

htcfreek commented Aug 7, 2020

Example image including the things form the last three comments:
About_01

@crutkas, @niels9001
Should we optimise the available links like shown in the picture. Then we have to reopen this issue or ned to create a new one.

@crutkas
Copy link
Member

crutkas commented Aug 7, 2020

Right now this is what it is based off Master.
image

I think maybe we do sections

Feedback
Open Source
Notices

@crutkas crutkas reopened this Aug 7, 2020
@crutkas
Copy link
Member

crutkas commented Aug 7, 2020

Sorry

Sections

@crutkas crutkas changed the title "About PowerToys" section Tweak "About PowerToys" in General settings tab into sections Aug 7, 2020
@crutkas crutkas added the Cost-Small Small work item - 0-8 hours of work label Aug 7, 2020
@htcfreek
Copy link
Collaborator Author

htcfreek commented Aug 8, 2020

Sorry

Sections

Yes.
And I think we should use the existing MDL2 Assets symbols (feedback, bug) in the feedback section.

@niels9001 niels9001 self-assigned this Dec 2, 2020
@niels9001
Copy link
Contributor

This is the latest state of the general page side bar:

image

Is this topic still alive? And what is the main benefit to add subtitles? Feels to me like more localization work (and space taken when in compact mode) with limited benefit..

@htcfreek
Copy link
Collaborator Author

@niels9001

  1. The idea was to have the same layout like on the other pages.
  2. There are two explanation sentences I suggested to add.
  3. Onather idea was to add a link to "How to contribute" article in our repro.

@enricogior
Copy link
Contributor

@niels9001 @htcfreek
I think the current UI is good enough, we have a lot of work ahead for OOBE, let's not spend time on nits that are not improving the user experience.

@htcfreek
Copy link
Collaborator Author

@niels9001 @htcfreek
I think the current UI is good enough, we have a lot of work ahead for OOBE, let's not spend time on nits that are not improving the user experience.

That is okay for me. If we don't need the opinion of @crutkas we can close this issue.

@crutkas
Copy link
Member

crutkas commented Dec 24, 2020

I’m fine leaving it as is for now.

@crutkas crutkas closed this as completed Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Cost-Small Small work item - 0-8 hours of work Product-Settings The standalone PowerToys Settings application
Projects
None yet
Development

No branches or pull requests

5 participants