Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancyzones causes tabs to disappear when trying to snap it back with other tabs #3504

Closed
ion-elgreco opened this issue May 22, 2020 · 10 comments
Labels
Product-FancyZones Refers to the FancyZones PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Regression This was working in a previous release

Comments

@ion-elgreco
Copy link

Environment

Windows build number: Microsoft Windows [Version 10.0.18363.836]
PowerToys version: v0.18.0
PowerToy module for which you are reporting the bug (if applicable): Fancyzones

Steps to reproduce

  1. Install brave browser
  2. Open up two tabs in separate windows.
  3. Turn on fancyzones
  4. Drag one tab into the other, so that your browser window has two tabs. Try to do this a couple of times and you will see the tab just disappears

Expected behavior

Tab has to snap into the browser

Actual behavior

Tab is crashing and closes instantly when you snap it in. This doesn't happen when fancyzones is off.

Screenshots

https://imgur.com/a/waAREAi

I was not able to record whole screen, but I am dragging a tab into the other one and it just crashes. In the video you even see it being attached and then closing, but what I am seeing is just an instant close on my screen.

@enricogior enricogior added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 22, 2020
@enricogior
Copy link
Contributor

Hi @ion-elgreco
can you please share your FancyZones settings?
Thank you.

@enricogior enricogior added the Product-FancyZones Refers to the FancyZones PowerToy label May 22, 2020
@ion-elgreco
Copy link
Author

Hi @ion-elgreco
can you please share your FancyZones settings?
Thank you.

Annotation 2020-05-22 110001

@enricogior
Copy link
Contributor

The target window is in a zone, right?
I can reproduce the problem only in that case.
The problem is not something we can fix, it's happening because the tab it's actually zoned while also merged and the Brave browser can't handle that case.
If you turn on Hold Shift key to activate zones while dragging the problem should not happen. Can you confirm?

@ion-elgreco
Copy link
Author

ion-elgreco commented May 22, 2020

The target window is in a zone, right?

Yes it is.

I can reproduce the problem only in that case.
The problem is not something we can fix, it's happening because the tab it's actually zoned while also merged and the Brave browser can't handle that case.

But this behavior is only with with the recent update afaik.

If you turn on Hold Shift key to activate zones while dragging the problem should not happen. Can you confirm?

This is a workaround, but now I need to hold shift every time, which is not practical.

@enricogior
Copy link
Contributor

But this behavior is only with with the recent update afaik.

You are right, it's a regression introduced in 0.18.
I tested the current 0.18.1 (that should be released later today) and it seems to be fixed.
Let's keep the issue open until you can test it with 0.18.1.
Thank you.

@enricogior enricogior added Severity-Regression This was working in a previous release and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 22, 2020
@enricogior enricogior added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label May 22, 2020
@ion-elgreco
Copy link
Author

But this behavior is only with with the recent update afaik.

You are right, it's a regression introduced in 0.18.
I tested the current 0.18.1 (that should be released later today) and it seems to be fixed.
Let's keep the issue open until you can test it with 0.18.1.
Thank you.

Alrighty then, I will give you an update if I have the new version.

@crutkas
Copy link
Member

crutkas commented May 22, 2020

tracked from #534 when we reopened

@crutkas
Copy link
Member

crutkas commented May 22, 2020

We just released 0.18.1 which will have this fix included in it.

@crutkas crutkas closed this as completed May 22, 2020
@ion-elgreco
Copy link
Author

ion-elgreco commented May 22, 2020

We just released 0.18.1 which will have this fix included in it.

It has fixed the issue of disappearing tabs, but new unwanted behavior is introduced. If I drag a tab now to the window, it will freeze or turn black. Then I cant close the tab anymore and I have to force close the application.

Opened a new issue: #3536

@jamehealy
Copy link

For what it's worth, this obviously (or maybe not so obviously) also addresses the same issue in the Microsoft Edge Chromium browser it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-FancyZones Refers to the FancyZones PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Regression This was working in a previous release
Projects
None yet
Development

No branches or pull requests

4 participants