Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-spelling: Remove stray field #11339

Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented May 18, 2021

This feature isn't ready yet and wasn't meant to be included

Summary of the Pull Request

What is this about:
Remove comment handler (unintentionally included in #11114)

(It's fairly harmless as configured, but the noise is worth removing, the event handler should come back w/ the next release when the code is ready...)

What is include in the PR:
Remove an event handler for a future feature

How does someone test / validate:
Be a non-member of the repository and comment on a PR (or check the repository actions list)

I think. (Oddly this event is failing way less than expected.)

Quality Checklist

  • Linked issue: #xxx
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

This feature isn't ready yet and wasn't meant to be included
@enricogior enricogior merged commit 58d41d4 into microsoft:master May 18, 2021
@jsoref jsoref deleted the spell-check-handle-comments-later branch May 18, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants