-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT Run][New Plugin] Unit Converter (#9800) #11406
Conversation
c063b86
to
cc275fa
Compare
@ThiefZero |
We should add a list of open problems/work items to this pr description. Only for saving it somehow and even if we plan to fix it in a separate PR/Issue. @ThiefZero |
@htcfreek, I had accidentally included an unfinished feature, but it should be gone as long as your code is current on both sides: 58d41d4 Otherwise, you get one comment for your Push and one comment for the Pull Request (if you push w/o creating a PR, you can fix things up before you create the PR). |
Everything seems to be working here 👍. Future improvements:
|
@jsoref |
Issue created to track the localization task #11429 |
New plugin checklist: New plugin checklist
|
@enricogior: eww, no, that's definitely worth investigating. Things one can do (on a branch not tied to a PR, possibly even in a personal repository):
I'll investigate later today. Do note that @microsoft deleted some comments e.g. #11406 (comment) – I'm not sure what they said. I've made some changes recently to the logging output which should help a little, but this gives me the idea that I should ensure that the number of unrecognized words is reported in the logs. |
@enricogior: check-spelling-sandbox@cc275fa#commitcomment-51227973 @check-spelling-bot ReportUnrecognized words, please review:
... To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the [email protected]:check-spelling/PowerToys.git repository
If you see a bunch of garbageIf it relates to a ... well-formed patternSee if there's a pattern that would match it. If not, try writing one and adding it to the Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines. Note that patterns can't match multiline strings. binary-ish stringPlease add a file path to the File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
@ThiefZero: Personally, I'd recommend adding a
|
Fwiw, the prerelease version handles this much better: https://github.com/check-spelling/PowerToys/runs/2657003343?check_suite_focus=true#step:4:23
I'm going to remove the url it's spitting out before I think I'm going to change @check-spelling-bot ReportPlease review:Unrecognized words (1)
|
src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.UnitConverter/InputInterpreter.cs
Outdated
Show resolved
Hide resolved
src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.UnitConverter/plugin.json
Outdated
Show resolved
Hide resolved
src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.UnitConverter/plugin.json
Outdated
Show resolved
Hide resolved
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentapos autoupdate bc bh Chris's classmethod cls CMDARG cn cx cz deque df dw EB ev fd fody fx getmembers gh hc hh hk hu ip ismethod jp Kf lambson laute loadingbar messagebox multithreading nonwin NX overlaywindow pb Pn pv pw px QI rpc ru rv rx sz tadele td tt tw Tz ul unitconvert uv vh vk vm vw Vx wostringstream xa XY yy Zc zh zipfolder zmTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the [email protected]:microsoft/PowerToys.git repository
If you see a bunch of garbageIf it relates to a ... well-formed patternSee if there's a pattern that would match it. If not, try writing one and adding it to the Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines. Note that patterns can't match multiline strings. binary-ish stringPlease add a file path to the File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
|
@enricogior add a
per #11406 (comment) and the spell-checker should stop complaining. |
src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.UnitConverter/UnitHandler.cs
Outdated
Show resolved
Hide resolved
We might want to consider adding telemetry so we know how often it is used. Probably it should be added to the PowerToys Run infrastructure code. |
src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.UnitConverter/Main.cs
Outdated
Show resolved
Hide resolved
src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.UnitConverter/Main.cs
Outdated
Show resolved
Hide resolved
@ThiefZero |
Does anyone have an idea how we can show the available units best? Mayba a list on docs.microsoft and a hint "(See available units in our docs.)" in the description. |
It currently does not. I took a quick look around in
Do you mean in the Settings's plugin list? I see that |
If you want to make changes to this branch create a pr into this branch. |
abd45f7
to
774a2fa
Compare
…itConverter/Main.cs
@ThiefZero |
I'll give it a go 😎 |
I read through the doc and added
added here as well? |
@ThiefZero |
|
@crutkas |
@ThiefZero |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested works as expected.
@ThiefZero great job!
Thanks, and thank you for the help refactoring/cleaning things up. 😄 I've got a question though, I was looking forward to see my contribution stats and I checked the Insights page for them, but there's no entry at all under my name (#lines/commits etc.). Did I do something wrong? I figured it should be in there now that it's (finally) been merged to master 🤔 It's my first open source code contribution so let me know if I messed up somewhere |
@ThiefZero |
Hi @ThiefZero , |
@mykhailopylyp Thank you for the effort and quick response. I can see myself in the list now, much love! 🥳 |
Summary of the Pull Request
What is this about:
See #9800
What is include in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.