Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runner] removed outdated MSIX code #11450

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

enricogior
Copy link
Contributor

Summary of the Pull Request

What is this about:
Clean up runner's outdated code.

What is include in the PR:
Remove outdated code that was detecting the MSIX version

How does someone test / validate:
Test the core main functionality at startup:

  • check if when a second instance is started, the Settings app is opened
  • check that a toast notification is correctly handled
  • check that a first time run opens OOBE

Quality Checklist

  • Linked issue: [runner] clean up startup procedure #11352
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@enricogior enricogior requested a review from yuyoyuppe May 25, 2021 10:44
@enricogior enricogior added the Area-Runner The PowerToys main executable label May 25, 2021
@crutkas
Copy link
Member

crutkas commented Jun 3, 2021

@yuyoyuppe any reason to not merge this in?

@yuyoyuppe yuyoyuppe merged commit 367b3df into microsoft:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Runner The PowerToys main executable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants