Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report Tool] Report event viewer logs #11458

Merged
merged 7 commits into from
May 26, 2021

Conversation

mykhailopylyp
Copy link
Contributor

@mykhailopylyp mykhailopylyp commented May 25, 2021

Summary of the Pull Request

What is this about:
We query for event viewer logs specific to PowerToys and report them. It is useful to correlate bug reports with Watson. Usually, Watson has memory dumps of crashes that are useful. Also, some crashes are not logged so it is useful to have at least some information about crashes.

We report XAML view from the event viewer.

image

Based on https://docs.microsoft.com/en-us/windows/win32/wes/querying-for-events

Take into account, that xaml isn't very readable especially EventData section. For example, to get a Hashed bucket(correlation id for watson) we need to go to Windows Error Reporting xaml and take second to the end Data in EventData section.

What is include in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: #xxx
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@mykhailopylyp mykhailopylyp added the Area-Bug Report Tool Issues around the Bug Report Tool from PowerToys label May 25, 2021
@mykhailopylyp
Copy link
Contributor Author

Still working on XAML formating.
Also, we should decide if we want to include all PowerToys processes to be reported.

@mykhailopylyp mykhailopylyp marked this pull request as draft May 25, 2021 16:23
@microsoft microsoft deleted a comment from github-actions bot May 26, 2021
@microsoft microsoft deleted a comment from github-actions bot May 26, 2021
@mykhailopylyp mykhailopylyp marked this pull request as ready for review May 26, 2021 12:50
@mykhailopylyp mykhailopylyp merged commit 0b13c4d into microsoft:master May 26, 2021
@mykhailopylyp mykhailopylyp deleted the report-even-viewer-logs branch May 26, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Bug Report Tool Issues around the Bug Report Tool from PowerToys
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants