Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OOBE] Open minimized settings #11546

Merged
merged 1 commit into from
Jun 2, 2021
Merged

[OOBE] Open minimized settings #11546

merged 1 commit into from
Jun 2, 2021

Conversation

davidegiacometti
Copy link
Collaborator

Summary of the Pull Request

What is this about:
Small fix for minimized settings window not brought to front when opened from OOBE.

How does someone test / validate:

  • Open Settings window from tray icon
  • Open OOBE window from "Welcome to PowerToys" link
  • Minimize Settings window
  • Open Settings from the OOBE window > Welcome > Settings button
  • Settings window should be brought to front and displayed

Quality Checklist

  • Linked issue: Settings window is not brought to front  #10994
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@davidegiacometti davidegiacometti added Product-Settings The standalone PowerToys Settings application Area-OOBE First time run experience for users labels May 31, 2021
mykhailopylyp
mykhailopylyp approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@mykhailopylyp mykhailopylyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested works as expected.

@crutkas crutkas merged commit a8ff1c8 into master Jun 2, 2021
@crutkas crutkas deleted the users/davidegiacometti/issue-10994 branch June 2, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykhailopylyp mykhailopylyp mykhailopylyp approved these changes

Assignees
No one assigned
Labels
Area-OOBE First time run experience for users Product-Settings The standalone PowerToys Settings application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidegiacometti @mykhailopylyp @crutkas