Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run-Plugin] Settings plugin #11663

Merged
merged 59 commits into from
Jun 9, 2021
Merged

Conversation

mykhailopylyp
Copy link
Contributor

@mykhailopylyp mykhailopylyp commented Jun 8, 2021

Summary of the Pull Request

What is this about:
For details look at #9137
What is include in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: #xxx
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@mykhailopylyp mykhailopylyp added the Run-Plugin Things that relate with PowerToys Run's plugin interface label Jun 8, 2021
@htcfreek
Copy link
Collaborator

htcfreek commented Jun 8, 2021

Will you only fix the last things to get this in? (And further improvements in a second step?)

@mykhailopylyp
Copy link
Contributor Author

Here's remaining work:

@mykhailopylyp
Copy link
Contributor Author

Will you only fix the last things to get this in? (And further improvements in a second step?)

yes

@htcfreek
Copy link
Collaborator

htcfreek commented Jun 8, 2021

What should the unit test project test? How will it works?

Do we need to update UnitTests in future if we change something on the result layout/make things optional?

@mykhailopylyp mykhailopylyp force-pushed the user/TobiasSekan/SettingsPlugin branch from de28075 to 55eff09 Compare June 8, 2021 17:53
@mykhailopylyp
Copy link
Contributor Author

mykhailopylyp commented Jun 9, 2021

Created issues for the remaining work

@htcfreek @TobiasSekan
If you have anything in mind that should be done here create issues for it.

@htcfreek
Copy link
Collaborator

htcfreek commented Jun 9, 2021

Created issues for the remaining work

okay

@htcfreek @TobiasSekan
If you have anything in mind that should be done here create issues for it.

Done in this PR or after this PR?

@mykhailopylyp
Copy link
Contributor Author

@htcfreek

Done in this PR or after this PR?

after this PR

@htcfreek
Copy link
Collaborator

htcfreek commented Jun 9, 2021

Van we create a tracking issue?

This is my personal list (not up to date):

  • Improve subtitle and area property (see issue ...)

  • Fix possible translation bug

  • Fix possible bug where results without alt. names not shown

  • Improve and align resource string naming (see PR comment)

  • Rename ResourceHelper => JsonSettingsListHelper (see PR comment)

  • Updating some WindowsSettings

    • ODBC
    • Get Started
    • Personalization (category)
    • ...
  • Prevent false positives in translation by adding check for empty settings property before translation.

Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick round of testing, works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants