-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Run-Plugin] Settings plugin #11663
[Run-Plugin] Settings plugin #11663
Conversation
Will you only fix the last things to get this in? (And further improvements in a second step?) |
Here's remaining work:
|
yes |
What should the unit test project test? How will it works? Do we need to update UnitTests in future if we change something on the result layout/make things optional? |
… ControlPanel prefix in json
…re placeholders for the translation
…ndowsSettings/Helper/UnsupportedSettingsHelper.cs Co-authored-by: Heiko <[email protected]>
…ndowsSettings/Helper/UnsupportedSettingsHelper.cs Co-authored-by: Heiko <[email protected]>
…ndowsSettings/Helper/UnsupportedSettingsHelper.cs Co-authored-by: Heiko <[email protected]>
de28075
to
55eff09
Compare
Created issues for the remaining work
@htcfreek @TobiasSekan |
okay
Done in this PR or after this PR? |
after this PR |
Van we create a tracking issue? This is my personal list (not up to date):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick round of testing, works well.
Summary of the Pull Request
What is this about:
For details look at #9137
What is include in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.