Fix CurrentVirtualDesktop fetching from registry
#11760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…back CurrentVirtualDesktop
|
@DHowett can you compare how Terminal did this and if we're correct here? |
|
Terminal implemented the check for the new version before the old version. |
|
@nitroin
|
|
Yep, of course, I'll try to mimic how terminal code behave. |
|
PR updated. Fun fact: the code was already very similar, now is practically the same. |
Funny you should mention that! Terminal copy/pasted this from the PT codebase. 😄 |
DHowett
approved these changes
Jun 17, 2021
royvou
pushed a commit
to royvou/PowerToys
that referenced
this pull request
Jul 7, 2021
* fix(microsoft#11125): fallback to canonical regkey session unaware * chore(microsoft#11125): use wil::unique_hkey instead of HKEY for fallback CurrentVirtualDesktop * refactor: extract new explorer current virtual desktop behavior into a separate method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
CurrentVirtualDesktopfetching from registryWhat is this about:
On various Windows versions (from 21370.1 upwards) the current virtual desktop id is persisted in:
Instead of:
What is include in the PR:
Fallback check to read the correct registry key.
How does someone test / validate:
See repro steps #11125.
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.