[Run-Plugin][Windows Search] Don't crash if URI can't be parsed #11788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykhailopylyp
added
the
Run-Plugin
crutkas
approved these changes
Jun 17, 2021
| @@ -49,7 +50,12 @@ public List<SearchResult> ExecuteQuery(ISearchQueryHelper queryHelper, string ke | |||
| // # is URI syntax for the fragment component, need to be encoded so LocalPath returns complete path | |||
| // Using OrdinalIgnoreCase since this is internal and used with symbols | |||
| var string_path = ((string)oleDBResult.FieldData[0]).Replace("#", "%23", StringComparison.OrdinalIgnoreCase); | |||
| var uri_path = new Uri(string_path); | |||
|
|
|||
There was a problem hiding this comment.
Do we have a unit test for this. What is a invalid example
There was a problem hiding this comment.
We don't have unit tests for the Microsoft.Plugin.Indexer plugin at all
There was a problem hiding this comment.
What is a invalid example
We don't know the string that can not be parsed for the user. But we log the string if it can not be parsed now.
yuyoyuppe
approved these changes
Jun 17, 2021
SeraphimaZykova
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
If URI parsing fails we fail to get any results from the Windows search plugin.
What is include in the PR:
If parsing of the URI fails log warning and skip the item.
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.