Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerToys Run] URI Plugin: handle numeric input #11885

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

davidegiacometti
Copy link
Collaborator

Summary of the Pull Request

What is this about:
Handle numeric input for URI plugin.

What is include in the PR:
Numeric input was converted into an IP address. This is the behaviour of System.Uri.

How does someone test / validate:

  • Search in PT Run for:
    • 12345 should display no results.
    • 12345.com should display http://12345.com/ as result.

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@davidegiacometti davidegiacometti added the Run-Plugin Things that relate with PowerToys Run's plugin interface label Jun 27, 2021
Copy link
Contributor

@mykhailopylyp mykhailopylyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested, works as expected.
Thank you for your contribution!

@mykhailopylyp mykhailopylyp merged commit 3f70c8c into master Jul 5, 2021
@mykhailopylyp mykhailopylyp deleted the users/davidegiacometti/issue-11796 branch July 5, 2021 14:40
royvou pushed a commit to royvou/PowerToys that referenced this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants