Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: remove hwnd_data_cache #1223

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Common: remove hwnd_data_cache #1223

merged 2 commits into from
Feb 6, 2020

Commits on Feb 6, 2020

  1. Common: remove hwnd_data_cache 

    The cache was introduced to improve performance by not querying the
OS for the window process path every time we need to check if the window
is interesting to FancyZones. Since then other changes where made to the
way we check the windows. Right now, the IsInterestingWindow function is
called when:

  1) WinKey + arrows are used
  2) window is started to be dragged
  3) window is created

1) and 2) are initiated by the user, happen only once per interaction so
their performance impact can be dismissed. The 3) happens all the time,
but for the most part the check for WS_CHILD or
GetAncestor(window, GA_ROOT) == window will filter those out. In the
end only top-level windows will be queried for their path.

Removing the cache improves code readability and will make code
maintenance easier.
    @bzoz
    bzoz committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    93d453d View commit details
    Browse the repository at this point in the history

  2. fixup: comment and make is_system_window require class_name

    @bzoz
    bzoz committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    1b5d0b1 View commit details
    Browse the repository at this point in the history