Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FancyZones] Revisit mutexes #12240

Merged
merged 7 commits into from
Jul 7, 2021
Merged

[FancyZones] Revisit mutexes #12240

merged 7 commits into from
Jul 7, 2021

Conversation

SeraphimaZykova
Copy link
Collaborator

Summary of the Pull Request

What is this about:

Summarizing changes:

  • Removed mutexes
  • Refactored FancyZones
  • Removed IZoneWindowHost
  • Renamed ZoneWindow -> WorkArea

What is include in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: [FancyZones] Revisit mutexes #11892
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@SeraphimaZykova SeraphimaZykova requested review from yuyoyuppe, stefansjfw and mykhailopylyp and removed request for yuyoyuppe July 6, 2021 09:40
@SeraphimaZykova SeraphimaZykova added the Product-FancyZones Refers to the FancyZones PowerToy label Jul 6, 2021
yuyoyuppe
yuyoyuppe approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@yuyoyuppe yuyoyuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested the following scenarios:

  • virtual deskops creation/deletion
  • grid/columns/custom layout creation
  • Win+arrows zoning
    Didn't notice any hangs/crashes.
    Awesome work!

@stefansjfw
Copy link
Collaborator

Looks good. Tested manually basic FZ functionalities including VDs

mykhailopylyp
mykhailopylyp approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@mykhailopylyp mykhailopylyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with fancyzones checklist

@SeraphimaZykova SeraphimaZykova merged commit d85c3f8 into master Jul 7, 2021
@SeraphimaZykova SeraphimaZykova deleted the feature/fancyzones-mutex branch July 7, 2021 10:18
royvou pushed a commit to royvou/PowerToys that referenced this pull request Jul 7, 2021
@SeraphimaZykova @royvou
[FancyZones] Revisit mutexes (microsoft#12240)
af981f1 
* [FancyZones] Clean up (microsoft#11893)

* [FancyZones] Virtual desktop utils refactoring (microsoft#11925)

* [FancyZones] IFancyZonesCallback refactoring (microsoft#11932)

* [FancyZones] IZoneWindowHost refactoring (microsoft#12091)

* [FancyZones] Rename ZoneWindow -> WorkArea (microsoft#12223)

* [FancyZones] Clean up mutexes (microsoft#12228)
@stefansjfw stefansjfw mentioned this pull request Jul 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefansjfw stefansjfw stefansjfw approved these changes

@mykhailopylyp mykhailopylyp mykhailopylyp approved these changes

@yuyoyuppe yuyoyuppe yuyoyuppe approved these changes

Assignees
No one assigned
Labels
Product-FancyZones Refers to the FancyZones PowerToy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SeraphimaZykova @stefansjfw @yuyoyuppe @mykhailopylyp