Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] Saving Excluded Apps on text changed #12318

Merged

Conversation

niels9001
Copy link
Contributor

@niels9001 niels9001 commented Jul 10, 2021

Summary of the Pull Request

When users made changes to the Excluded Apps list (both for FancyZones and Shortcut Guide) and closed the window, changes would not be saved (since it only saved on the LostFocus event of the TextBox) - resulting in: #12166

fzexcluded

Quality Checklist

  • Linked issue:Fancy Zones errors #12166
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@davidegiacometti
Copy link
Collaborator

ShortcutGuide settings should have the same behaviour.

@niels9001
Copy link
Contributor Author

ShortcutGuide settings should have the same behaviour.

Good catch, thanks. Fixed!

@niels9001 niels9001 changed the title [Settings] Saving FZ Excluded Apps on text changed [Settings] Saving Excluded Apps on text changed Jul 12, 2021
Copy link
Contributor

@dedavis6797 dedavis6797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dedavis6797 dedavis6797 merged commit d3cd7be into master Jul 12, 2021
@dedavis6797 dedavis6797 deleted the users/niels9001/settings-propertychangedfzexcludedapps branch July 12, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants