FancyZones editor magnetic snapping effect #1277

ivan100sic · 2020-02-12T10:37:28Z

Implemented a solution to Issue #585: FancyZones: Alignment/Snapping/Ruler

Summary of the Pull Request

This PR implements one aspect of Issue #585. Now, windows in the Canvas zone editor will snap to each other when being moved and resized.

References

PR Checklist

[] Applies to FancyZones: Alignment/Snapping/Ruler #585
[] CLA signed. If not, go over here and sign the CLA
[] Tests added/passed
[] Requires documentation to be updated
[] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

There are two implementations of snapping available, but only one is being used.

Validation Steps Performed

Manually tested the Canvas zone editor in various scenarios.

crutkas · 2020-02-12T12:40:28Z

let’s hold on merging until 0.15 ships please

enricogior · 2020-02-12T14:53:32Z

Yes, sure.

Implemented a solution to Issue microsoft#585: FancyZones: Alignment/Snapping/Ruler

…deleted. (microsoft#1415)

* Getting ready for v0.15 update for readme. * getting ready for 0.15 * spelling tweak * filled in update section * fixed spelling mistakes * updating to what POR is * Update README.md * Update README.md * adding back in MSI * getting readme ready for 0.15 * tweaks * adding oss to oss links * fixing links * tweaking file names * Update README.md * Update README.md * Update README.md fixing typo * Update README.md

…soft#1426)

* Fix migrating never applied custom zonesets * Handle json parsing exception in LoadCustomModels()

* adding preview tag for desktop and start menu * getting to load, code from wixtoolset/issues#5700 (comment)

src/modules/fancyzones/editor/FancyZonesEditor/CanvasZone.xaml.cs

* Fix PowerRename UI doesn't handling DPI changes * Address PR comments * Address PR comments

Fixed an issue (microsoft#365) where a window gets resized after it gets dropped into a zone.

…#1458) * Fixed an issue where zones do not fill up the whole screen * Fixup: Added comments, removed extra semicolons

* Update dllmain.cpp * Update dllmain.cpp

* Switch WindowWalker C# project to use PackageReference * Remove packages.config leftovers Co-authored-by: William Kent <[email protected]>

enricogior · 2020-03-09T08:20:18Z

src/modules/fancyzones/editor/FancyZonesEditor/CanvasZone.xaml.cs

        }

-        private void SWResize_DragDelta(object sender, System.Windows.Controls.Primitives.DragDeltaEventArgs e)
+        private Settings _settings = ((App)Application.Current).ZoneSettings;


_settings is not used anymore, right?

Yes, that can safely be removed.

enricogior · 2020-03-09T08:23:43Z

src/modules/fancyzones/editor/FancyZonesEditor/CanvasZone.xaml.cs

+            ///     Just pass it the canvas arguments. Use mode
+            ///     to tell it which edges of the existing masks to use when building its list
+            ///     of snap points, and generally which edges to track. There will be two
+            ///     SnappyHelpers, one for X-coordinates and one for
+            ///     Y-coordinates, they work independently but share the same logic.


Better formatting:

/// Just pass it the canvas arguments. Use mode to tell it which edges /// of the existing masks to use when building its list of snap points, /// and generally which edges to track. There will be two SnappyHelpers, /// one for X-coordinates and one for Y-coordinates, they work /// independently but share the same logic.

Agreed, I'll unindent these 5 lines.

enricogior · 2020-03-09T08:36:18Z

@ivan100sic
when a custom layout is created, it's permanently bound to the current screen size. Changing the monitor scaling will result in the layout to not being able to use the increased screen size, or to go out of bound if the new screen size is smaller.

enricogior · 2020-03-09T08:39:37Z

src/modules/fancyzones/editor/FancyZonesEditor/CanvasZone.xaml.cs

+            ModeLow = 1,
+            ModeHigh = 2,
+            ModeBoth = 3,


Since the enum already states that this is the ResizeMode, I would suggest to rename the values to:

BottomEdge

TopEdge

BothEdges

Perhaps LowEdge, HighEdge, BothEdges?

Top and Bottom are better terms in this case.

Or are these referring to the Y axis as well?

They are used in both X and Y axes.

In case of Y, top edge is the left edge, correct?

src/modules/fancyzones/editor/FancyZonesEditor/CanvasZone.xaml.cs

Implemented a solution to Issue microsoft#585: FancyZones: Alignment/Snapping/Ruler

…/PowerToys into snapping-improved-new

ivan100sic · 2020-03-09T10:38:09Z

I messed up the history on this branch, so I'm closing this pull request in favor of #1503

ivan100sic force-pushed the snapping-improved-new branch from 2a8ea69 to f913c5d Compare February 12, 2020 10:43

ivan100sic changed the title ~~Finished implementing the magnetic snapping effect~~ FancyZones editor magnetic snapping effect Feb 12, 2020

enricogior mentioned this pull request Feb 13, 2020

Custom zones should have magnetic edges (snap to each other) #191

Closed

enricogior added this to the 20.02 release milestone Feb 14, 2020

ivan100sic added 2 commits March 2, 2020 11:25

FancyZones editor magnetic snapping effect

ab67a5d

Implemented a solution to Issue microsoft#585: FancyZones: Alignment/Snapping/Ruler

Fixed VS complaining about names and access modifiers

7903445

ivan100sic force-pushed the snapping-improved-new branch from 74b0660 to 7903445 Compare March 2, 2020 10:25

ivan100sic and others added 10 commits March 2, 2020 11:34

Removed reference to unused implementation of snapping in FZE

e9fd119

Skip cloning device information from parent virtual desktop if it is …

6556e1b

…deleted. (microsoft#1415)

Update README.md (microsoft#1412)

b2370f5

Sanity check for imported settings that may have invalid data. (micro…

f3b3e3e

…soft#1426)

Fix migrating never applied custom zonesets (microsoft#1427)

121be77

Handle exception while editor is parsing custom layouts (microsoft#1430)

0199b4e

* Fix migrating never applied custom zonesets * Handle json parsing exception in LoadCustomModels()

Increment version to 0.15.1 (microsoft#1428)

6787af4

Now working on 0.15.2 (microsoft#1432)

8373204

Fix for msi not loading on visual studio (microsoft#1385)

75ed3ce

* adding preview tag for desktop and start menu * getting to load, code from wixtoolset/issues#5700 (comment)

crutkas removed this from the 20.02 release milestone Mar 4, 2020

enricogior requested review from vldmr11080 and stefansjfw March 4, 2020 23:35

vldmr11080 and others added 2 commits March 5, 2020 08:01

Swallow shift keyboard event when dragging window (microsoft#1423)

39cac39

MSIX: use com_object_factory for powerrename

84fbdba

PrzemyslawTusinski reviewed Mar 5, 2020

View reviewed changes

src/modules/fancyzones/editor/FancyZonesEditor/CanvasZone.xaml.cs Outdated Show resolved Hide resolved

src/modules/fancyzones/editor/FancyZonesEditor/CanvasZone.xaml.cs Outdated Show resolved Hide resolved

ivan100sic and others added 4 commits March 5, 2020 10:02

Converted integer constants to enums in FZE/Canvas

d509a95

Convert a portion of code to a switch statement

12d0a2c

Fix PowerRename UI doesn't handling DPI changes (microsoft#1424)

6a0061d

* Fix PowerRename UI doesn't handling DPI changes * Address PR comments * Address PR comments

Fixed multi-monitor scaling bug (microsoft#1293)

92f6418

Fixed an issue (microsoft#365) where a window gets resized after it gets dropped into a zone.

ivan100sic and others added 9 commits March 5, 2020 15:54

Fixed an issue where zones do not fill up the whole screen (microsoft…

9860e2b

…#1458) * Fixed an issue where zones do not fill up the whole screen * Fixup: Added comments, removed extra semicolons

Fixed resizer thumbs not being shown (microsoft#1309)

985a0b9

adding in a Code of Conduct

32de0ae

Fixed one mishandled case when computing zones (microsoft#1470)

2b91903

Fix spelling mistake (microsoft#1476)

141b635

Move ZoneSetPersistedDataOLD to JsonHelpers (microsoft#1405)

1cf8634

Remove unused check for pClassFactory (microsoft#1419)

bea8e64

* Update dllmain.cpp * Update dllmain.cpp

Switch WindowWalker C# project to use PackageReference (microsoft#1374)

f6047b8

* Switch WindowWalker C# project to use PackageReference * Remove packages.config leftovers Co-authored-by: William Kent <[email protected]>

Update bundle.js and html index files. (microsoft#1502)

52e08a2

enricogior reviewed Mar 9, 2020

View reviewed changes

src/modules/fancyzones/editor/FancyZonesEditor/CanvasZone.xaml.cs Outdated Show resolved Hide resolved

enricogior reviewed Mar 9, 2020

View reviewed changes

src/modules/fancyzones/editor/FancyZonesEditor/CanvasZone.xaml.cs Outdated Show resolved Hide resolved

enricogior reviewed Mar 9, 2020

View reviewed changes

src/modules/fancyzones/editor/FancyZonesEditor/CanvasZone.xaml.cs Outdated Show resolved Hide resolved

enricogior reviewed Mar 9, 2020

View reviewed changes

src/modules/fancyzones/editor/FancyZonesEditor/CanvasZone.xaml.cs Outdated Show resolved Hide resolved

ivan100sic added 8 commits March 9, 2020 11:02

Improved code maintainability

5f7971e

FancyZones editor magnetic snapping effect

c99686f

Implemented a solution to Issue microsoft#585: FancyZones: Alignment/Snapping/Ruler

Fixed VS complaining about names and access modifiers

98f123b

Removed reference to unused implementation of snapping in FZE

88894b3

Converted integer constants to enums in FZE/Canvas

c646b58

Convert a portion of code to a switch statement

29a8c8d

Improved code maintainability

b91c3b7

Merge branch 'snapping-improved-new' of https://github.com/ivan100sic…

f4b0360

…/PowerToys into snapping-improved-new

ivan100sic mentioned this pull request Mar 9, 2020

FancyZones editor magnetic snapping effect #1503

Merged

2 tasks

ivan100sic closed this Mar 9, 2020

ivan100sic deleted the snapping-improved-new branch June 8, 2020 10:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FancyZones editor magnetic snapping effect #1277

FancyZones editor magnetic snapping effect #1277

ivan100sic commented Feb 12, 2020

crutkas commented Feb 12, 2020

enricogior commented Feb 12, 2020

enricogior Mar 9, 2020

ivan100sic Mar 9, 2020

enricogior Mar 9, 2020

ivan100sic Mar 9, 2020

enricogior commented Mar 9, 2020

enricogior Mar 9, 2020

ivan100sic Mar 9, 2020

enricogior Mar 9, 2020

enricogior Mar 9, 2020

ivan100sic Mar 9, 2020

enricogior Mar 9, 2020

ivan100sic commented Mar 9, 2020

FancyZones editor magnetic snapping effect #1277

FancyZones editor magnetic snapping effect #1277

Conversation

ivan100sic commented Feb 12, 2020

Summary of the Pull Request

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

crutkas commented Feb 12, 2020

enricogior commented Feb 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

enricogior commented Mar 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivan100sic commented Mar 9, 2020